Updating with mongoose using dynamic path

Question

My model looks like this:

var eventSchema = new mongoose.Schema({
    'eventTitle': String,
    'location': String,
    'startDate': String,
    'endDate': String,
    'startTime': String,
    'endTime': String,
    'createdBy': mongoose.Schema.Types.ObjectId, // Here we will store the _ID from the user EOSP.
    'attendants': {
        'seekers': [mongoose.Schema.Types.ObjectId],
        'employers': [
        //     {
        //         'id': mongoose.Schema.Types.ObjectId,
        //         'boothVisits': Number,
        //     }
        ],
    },
    'isFinished': {'type': Boolean, 'default': false},
    'uploadedResumes': Number,
    'downloadedResumes': Number,
});

And this is my code:

Event.findByIdAndUpdate(eventId, {$inc:{`attendants.employers[${req.params._id}].boothVisits`: 1}, $upsert: true});

So the problem is, if I try to do this ^^^^^ my node yells at me saying:

/home/alex/Documents/Projects/ontario-job-portal/routes/employer.js:58 Event.findByIdAndUpdate(eventId, {$inc: {attendants.employers[${req.params._id}].boothVisits: 1}, $upsert: true}); ^^^^^^^^^^^^^^^^^^^^^^^^

SyntaxError: Unexpected template string

But if I try to do this:

const path = `attendants.employers[${req.params._id}].boothVisits`;
Event.findByIdAndUpdate(eventId, {$inc: {path: 1}, $upsert: true});

My IDE tells me that the path variable is actually not used in the query. How can I get around it? I really need the id to be dynamic.

Try `Event.findByIdAndUpdate(eventId, {$inc:{attendants.employers.[req.params._id].boothVisits: 1}, $upsert: true});` — s7vr, Oct 16 '18 at 12:39
I like the idea, but this tells me `Event.findByIdAndUpdate(eventId, {$inc:{attendants.employers.[req.params._id].boothVisits: 1}, $upsert: true}); ^ SyntaxError: Unexpected token .` — Alex Ironside, Oct 16 '18 at 12:52
You're looking for creating object with dynamic key. Take a look at this answer: https://stackoverflow.com/questions/19837916/creating-object-with-dynamic-keys — willie17, Oct 16 '18 at 13:19

IftekharDani · Accepted Answer · 2018-10-17T11:07:49.900

1

Try with below query

Tested on mongo GUI.

const mongoose = require('mongoose');


db.getCollection('content')
  .update({
    'attendants.employers.id': mongoose.Types.ObjectId((req.params._id)
    }, {
    $inc: { "attendants.employers.$.boothVisits": 1 }
  })

edited Oct 17 '18 at 11:07

answered Oct 17 '18 at 05:23

IftekharDani

3,619
1
16
21

I see the logic here, but it doesn't seem to change anything. Catch doesn't throw any errors. It just doesn't increment. Any idea why? – Alex Ironside Oct 17 '18 at 10:59
change req.params._id with ObjectId(req.params._id) – IftekharDani Oct 17 '18 at 11:01
You also use `mongoose ` to convert string into `ObjectId` – IftekharDani Oct 17 '18 at 11:08
Thank you! Can you explain why this works? What is the `$` and why do I need the `mongoose.Types...`? – Alex Ironside Oct 17 '18 at 11:12
1

`req.params._id` is string and its not match in `mongodb` objectId. So, you need to convert to `ObjectId` to match in mongo – IftekharDani Oct 17 '18 at 11:17
1

for `$` you can refer https://docs.mongodb.com/manual/reference/operator/update/positional/ – IftekharDani Oct 17 '18 at 11:19

score 0 · Answer 2 · answered Oct 16 '18 at 12:43

0

try this?:

Event.findByIdAndUpdate(eventId,
     {
        $inc: { 'attendants.employers.boothVisits': {$in: [req.params._id] }: 1}, 
        $upsert: true
     });

answered Oct 16 '18 at 12:43

shuk

1,745
1
14
25

This tells me `/home/alex/Documents/Projects/ontario-job-portal/routes/employer.js:58 Event.findByIdAndUpdate(eventId, {$inc: { 'attendants.employers.boothVisits': {$in: [req.params._id] }: 1},$upsert: true}); ^ SyntaxError: Unexpected token : ` – Alex Ironside Oct 16 '18 at 12:52

Updating with mongoose using dynamic path

2 Answers2