How to stop for loop if response from api is false?

Question

How do I stop for loop if response comes false from the api?. I have below code for api integration. Now currently api is calling as per loop at one time. I want to do call the same api if response from the api is true. Below is my code

            for (let i = 0; i < this.fooditemselecteddetails.length; i++) {                   
                this.spinnerService.hide();     
                //console.log(this.fooditemselecteddetails);                          
                this.common.createAPIService('api/booking/AddConcessions?CinemaId=' + this.cinemaid + '&TransactionId=' + this.temptransaction.TransactionId + '&ItemId=' + this.fooditemselecteddetails[i].id + '&Quantity=' + this.fooditemselecteddetails[i].quantity + "&BookingId=" + this.transactionAPIRequest.ORDER_ID, '').subscribe((result: any) => {

                    this.spinnerService.hide();
                    this.addconcession = result;
                    console.log(this.addconcession);


                    if (this.addconcession.IsSuccess == true) {
                        if (i == this.fooditemselecteddetails.length - 1) {
                            localStorage.setItem("bookingid", this.transactionAPIRequest.ORDER_ID);
                            this.common.createAPIService('api/booking/FinalBookingDetails?BookingId=' + this.transactionAPIRequest.ORDER_ID, '').subscribe((result2: any) => {
                                this.vistavalidation = result2;
                                if (this.vistavalidation.BookingID > 0) {
                                    this.common.createAPIService('api/booking/ContinueTransaction?CinemaId=' + this.cinemaid + '&TransactionId=' + this.temptransaction.TransactionId, '').subscribe((result3: any) => {
                                        if (result3.IsSuccess) {
                                            this.ContinueTransactionresult = result3;
                                            this.showTabOnClick('tabs-4');
                                        }
                                        else {                                           
                                            this.common.ShowNotification("Food Item", result3.Error, "info");
                                            this.spinnerService.hide();
                                        }
                                    });
                                }
                                else {

                                    this.common.ShowNotification("Food Item", 'something went wrong, please try again', "info");
                                    this.spinnerService.hide();
                                }
                            });
                        }
                    }
                    else {

                        this.common.ShowNotification("Food Item", result.Error, "error");
                        this.spinnerService.hide();
                    }
                });
            }

I want to call AddConcessions? this api again if response from this api is true. If it's returns false then stop loop there only.

possibly related: https://stackoverflow.com/questions/2641347/short-circuit-array-foreach-like-calling-break — Ayush Gupta, Oct 20 '18 at 08:01

Sunil Singh · Accepted Answer · 2018-10-20T08:05:06.517

For this you need to run your service in Synchronous fashion.

Here is the change you can make to execute your code in sequence

addConcessions(i) {
   this.spinnerService.hide();     
                //console.log(this.fooditemselecteddetails);                          
                this.common.createAPIService('api/booking/AddConcessions?CinemaId=' + this.cinemaid + '&TransactionId=' + this.temptransaction.TransactionId + '&ItemId=' + this.fooditemselecteddetails[i].id + '&Quantity=' + this.fooditemselecteddetails[i].quantity + "&BookingId=" + this.transactionAPIRequest.ORDER_ID, '').subscribe((result: any) => {

                    this.spinnerService.hide();
                    this.addconcession = result;
                    console.log(this.addconcession);


                    if (this.addconcession.IsSuccess == true) {
                        if (i == this.fooditemselecteddetails.length - 1) {
                            localStorage.setItem("bookingid", this.transactionAPIRequest.ORDER_ID);
                            this.common.createAPIService('api/booking/FinalBookingDetails?BookingId=' + this.transactionAPIRequest.ORDER_ID, '').subscribe((result2: any) => {
                                this.vistavalidation = result2;
                                if (this.vistavalidation.BookingID > 0) {
                                    this.common.createAPIService('api/booking/ContinueTransaction?CinemaId=' + this.cinemaid + '&TransactionId=' + this.temptransaction.TransactionId, '').subscribe((result3: any) => {
                                        if (result3.IsSuccess) {
                                            this.ContinueTransactionresult = result3;
                                            this.showTabOnClick('tabs-4'); 
                                            index--;
                                            if(index >= 0){
                                              this.addConcessions(index);
                                            }
                                        }
                                        else {                                           
                                            this.common.ShowNotification("Food Item", result3.Error, "info");
                                            this.spinnerService.hide();
                                        }
                                    });
                                }
                                else {

                                    this.common.ShowNotification("Food Item", 'something went wrong, please try again', "info");
                                    this.spinnerService.hide();
                                }
                            });
                        }
                    }
                    else {

                        this.common.ShowNotification("Food Item", result.Error, "error");
                        this.spinnerService.hide();
                    }
                });

   }

call this function as

this.addConcessions(this.fooditemselecteddetails.length-1);

I did'nt get it. Can you please explain?. I'm new to backend — Sagar Kodte, Oct 20 '18 at 07:50
I understand there loop in another function. So you can remove the loop and put this call this function `addConcessions` as mentioned. It will make the recursive call until the error occurred or all items are completed — Sunil Singh, Oct 20 '18 at 07:53
So you mean make addConcessions(index) as another function and that function will call on place of for loop. rigtht? — Sagar Kodte, Oct 20 '18 at 07:55
Updated your question with changes so that we can figure out what is the issue now. — Sunil Singh, Oct 20 '18 at 08:04
Call this way `this.addConcessions(this.fooditemselecteddetails.length-1);` — Sunil Singh, Oct 20 '18 at 08:05
Can you please explain? I want to understand what you have done — Sagar Kodte, Oct 20 '18 at 08:42
Its recursive call of function `addConcessions`. It will call itself with next value if the current API is passed. — Sunil Singh, Oct 20 '18 at 09:02
Let us [continue this discussion in chat](https://chat.stackoverflow.com/rooms/182248/discussion-between-sagar-kodte-and-sunil-singh). — Sagar Kodte, Oct 22 '18 at 09:01

How to stop for loop if response from api is false?

1 Answers1