False instead of True (@gmail.com)

Question

I wrote an authenticator to see if an email ends with "@gmail.com". I don't really know why is this returns false. Could someone help me out why is it?

public static void main(String [] args){
    System.out.println(StringUtils.isValidGmail("a@gmail.com"));  // true
}


public static boolean isValidGmail(String email){
    if (email == null){
        return false;
    }
    int x = email.length() - 1;
    String gmail = email.substring(x-9, x+1);  // @gmail.com
    return gmail == "@gmail.com";
}

for string comparison use .equals() not == they do two separate type of checks. — arahman, Oct 30 '18 at 13:37
try `return gmail.equals("@gmail.com");` Read of course the link in the above comment for the explanation [-: — shadowsheep, Oct 30 '18 at 13:39
in addition there is another method exists for this particular problem. You don't event need to find the email part. Try, `if (email == null){ return false; } return gmail.endsWith( "@gmail.com")` — MD Ruhul Amin, Oct 30 '18 at 13:43

score 2 · Accepted Answer · answered Oct 30 '18 at 13:37

2

you should replace return gmail == "@gmail.com"; by return gmail.equals("@gmail.com");

answered Oct 30 '18 at 13:37

abdelmouheimen

136
2
16

1

Ok I see thank you very much – Dusernajder Oct 30 '18 at 13:40

False instead of True (@gmail.com)

1 Answers1