Can't push array in function

Question

I know this has been asked before but I can't seem to find the answer, my array can't push to datahasil, how to push array hasil to datahasil...??

const data1 = await JadwalBooking.aggregate([{
    $project: {
      "keterangan": "$keterangan",
      "jumlah_tersisa": "$datalayout.jumlah_kursi_tersisa",
      "flag": "$flag",
      "date1": "$datamisa.date",
    }
  },
  {
    $match: {
      flag: 1
    },
  },

], function(err, result) {
  var datahasil = []
  result.forEach(async(item) => {
    const hasil = await DetailBookingMisa.find({
      $or: [{
          flag: 3
        },
        {
          flag: 4
        }
      ],

      $and: [{
        jadwalbookingmisa: item._id
      }]
    }, )
    datahasil.push(hasil)
  })
});

suggestion: consider not to query database in a loop. – scetiner Nov 09 '18 at 08:26 — scetiner, Nov 09 '18 at 08:26
forEach + async is virtually never a good combination – Bravo Nov 09 '18 at 08:29 — Bravo, Nov 09 '18 at 08:29

dotconnor · Accepted Answer · 2018-11-09T08:32:44.000

You gave forEach function an asynchronous method removing its synchronous nature so instead, use map and await Promise.all on the resulting array:

const data1 = await JadwalBooking.aggregate([{
    $project: {
      "keterangan": "$keterangan",
      "jumlah_tersisa": "$datalayout.jumlah_kursi_tersisa",
      "flag": "$flag",
      "date1": "$datamisa.date",
    }
  },
  {
    $match: {
      flag: 1
    },
  },

], async function(err, result) {
  const datahasil = await Promise.all(result.map(async(item) => {
    const hasil = await DetailBookingMisa.find({
      $or: [{
          flag: 3
        },
        {
          flag: 4
        }
      ],

      $and: [{
        jadwalbookingmisa: item._id
      }]
    })
    return hasil;
  });
  console.log(datahasil);
});

Rather than `push`ing to an external array, probably better to just use the results of the `Promise.all` (one less variable, more pure) — CertainPerformance, Nov 09 '18 at 08:31

Can't push array in function

1 Answers1