forwarding response to another action in struts and sending file in response

Question

I'm forwarding an action to from doFilter method conditionally as the following code to another method :

    public void dofilter(ActionMapping mapping, ActionForm actionForm, HttpServletRequest request,
                              HttpServletResponse resp) {
    String reportType = request.getParameter("reportType");
    ActionForward actionForward = null;
    try {

       if (reportType.equals("completedChart")) {
                actionForward = cmsGetCompeltedTasks(mapping, actionForm,request, resp);

    } catch (Exception ex) {
        ex.printStackTrace();
    }

}

and my method that accepts the action and the response is that generates a jasper report file and sends it in the response :

    public ActionForward cmsGetCompeltedTasks(ActionMapping mapping, ActionForm form, HttpServletRequest request,
                                          HttpServletResponse response) throws Exception {
            JasperReport jasperReport =                     fileName = COMPLETED_TASK + format.format(new Date()).toString() + ".xlsx";
                String filePath = servlet.getServletContext().getRealPath("") + fileName;
                System.out.println(filePath);
                JRXlsxExporter exporter = new JRXlsxExporter();
                exporter.setParameter(JRExporterParameter.JASPER_PRINT, jasperPrint);
                exporter.setParameter(JRExporterParameter.OUTPUT_FILE_NAME, filePath);
                exporter.exportReport();                
                response.setContentType("application/vnd.openxmlformats-officedocument.spreadsheetml.sheet");
                response.addHeader("Content-Disposition", "attachment; filename=" + fileName);
                file = new File(filePath);
                FileInputStream fileInputStream = new FileInputStream(filePath);
                OutputStream responseOutputStream = response.getOutputStream();
                int bytes;
                while ((bytes = fileInputStream.read()) != -1) {
                    responseOutputStream.write(bytes);
                }
                responseOutputStream.flush();
                fileInputStream.close();
                 responseOutputStream.close();

        return mapping.findForward("cmsGetCompeltedTasks");


    } catch (Exception e) {
        e.printStackTrace();
    }           finally {
            file.delete();
        }

    return null;

}

But no file is downloading and I get an exception:

java.lang.IllegalStateException: Cannot forward after response has been committed

score 1 · Answer 1 · answered Dec 03 '18 at 14:21

1

You are writing to response in servlet and you should move it to JSP

just don't write to the response in the servlet. That's the responsibility of the JSP.

Move the lines using response to the JSP you redirect to

response.setContentType("application/vnd.openxmlformats- officedocument.spreadsheetml.sheet");
...

answered Dec 03 '18 at 14:21

Ori Marko

56,308
23
131
233

do you mean that i need to move all code that write to the response to be executed in the jsp ? – Mohammed Adel Dec 03 '18 at 14:28
@MohammedAdel yes – Ori Marko Dec 03 '18 at 14:28
1

Writing non-HTML responses in an action is perfectly acceptable. The issue is that the OP is trying to do two things in a single response, return a file, and forward to a JSP. – Dave Newton Dec 03 '18 at 16:09
@user7294900 i have written the code in jsp but nothing is downloading and i post the code in an answer on my question – Mohammed Adel Dec 03 '18 at 16:45
@DaveNewton - So, how to do two things in a single response? I would need that. – tec Jan 07 '19 at 15:48
@tomyforever You don't--that's not how responses work. You could redirect and then on *that* page start the download. – Dave Newton Jan 07 '19 at 17:55
@DaveNewton - Ok, and that would mean send 2 requests , one for the redirection, one for the download, doesn't it? – tec Jan 08 '19 at 07:51
@tomyforever No, it means you'd send two responses. – Dave Newton Jan 08 '19 at 08:49

score 0 · Accepted Answer · edited Jan 16 '19 at 12:36

0

The problem was that I was firing Ajax request and I send the file to download in servlet response but the file to be download was handled by Ajax request in JavaScript on the success callback not the servlet response I handled the issue to send a direct URL to the file I want to download in the Ajax success call back and fire a new request to the that file specific URL.

edited Jan 16 '19 at 12:36

brasofilo

25,496
15
91
179

answered Jan 16 '19 at 12:27

Mohammed Adel

177
1
3
10

forwarding response to another action in struts and sending file in response

2 Answers2