Delete dictionary from list dictionaries if the keys don't exist in a list

Question

abc = [123,345,678]
var = [{'name':'123, 'age':12},{name:345, 'age':32},{name:789,'age':39}]

I want to delete a the dictionary from var if the var['name'] doesn't exist in list abc.

final = [{'name':'123, 'age':12},{name:345, 'age':32}]

I tried the following

for i,element in enumerate(abc):
   if element['name'] in var.keys():
      element['salary'] = '50000'
   else:
       abc.pop(i)

it deletes some dicts, but leaves one dict

How have you tried to solve this? Please show us your attempt and explain how exactly it doesn't work — ForceBru, Dec 13 '18 at 18:43

score 3 · Answer 1 · answered Dec 13 '18 at 18:44

3

Here is a list comprehension method:

final = [v for v in var if v['name'] in abc]

answered Dec 13 '18 at 18:44

Gerges

score 3 · Answer 2 · answered Dec 13 '18 at 18:46

3

final = filter(lambda x: x['name'] in abc, var)

answered Dec 13 '18 at 18:46

Sergey Pugach

mad_ · Answer 3 · 2018-12-13T18:59:51.220

1

set_abc = set(abc)
final = [x for x in var if x['name'] in set_abc]

edited Dec 13 '18 at 18:59

answered Dec 13 '18 at 18:55

mad_

You're instantiating a new set for every iteration so it does not help the time complexity at all. You should instantiate the set before using it in the list comprehension. – blhsing Dec 13 '18 at 18:58
1

@blhsing makes sense. corrected – mad_ Dec 13 '18 at 19:00

3 Answers3