Query inside functions.php does not return posts, while working in template files

Question

Need to pull custom post type's titles and id's inside functions.php Following code is working fine if used in page template. But doesn't return anything inside a functions.php

<select name="feat_pop" value="<?php echo $feat_pop; ?>">
    <option value="none">None</option>
    <?php
        global $post;
        $popargs = array(                        
                            'posts_per_page' => -1, 
            'post_type' => 'popups'
        );
            $newpop = new WP_Query( $popargs );
        if ( have_posts() ) while ($newpop->have_posts()) : $newpop->the_post();
    ?>
            <option value=""><?php the_title();?></option>
    <?php
        endwhile; 
        wp_reset_postdata();
    ?>
</select>

The only error in error logs- "Got error 'PHP message: PHP Parse error: syntax error, unexpected end of file" But there is nothing at specified line.

You would need to show how it's implemented in `functions.php` for example did you just paste it in like this `` — ArtisticPhoenix, Dec 28 '18 at 23:05
Just so you're aware - removing the `if` helped because it's referencing the global query which isn't in the scope of (and is irrelevant to) your function — Xhynk, Dec 28 '18 at 23:24

score 1 · Answer 1 · answered Dec 28 '18 at 23:05

It looks like you're conflating the methods for the have_posts of your code. You should be running that method on your WP_Query(). You also shouldn't need to instantiate the global $post variable here. Lastly, you don't appear to actually be pulling the ID into your output anywhere? I assume you want it as the value - Try this:

<select name="feat_pop" value="<?php echo $feat_pop; ?>">
    <option value="none">None</option>
    <?php
        $popargs = array(                        
            'posts_per_page' => -1, 
            'post_type'      => 'popups'
        );

        $newpop = new WP_Query( $popargs );

        if( $newpop->have_posts() ){
            while( $newpop->have_posts() ){
                $newpop->the_post();                    
                echo '<option value="'. get_the_ID() .'">'. get_the_title() .'</option>';
            }
        }

        wp_reset_postdata();
    ?>
</select>

The `if` statement is not necessary `if( $newpop->have_posts() )` before `while( $newpop->have_posts() ){` if `$newpop->have_posts()` is false the loop doesn't execute (either way). — ArtisticPhoenix, Dec 28 '18 at 23:07
It's not strictly necessary, no - but it's arguably standard practice for WP Queries to more easily catch scenarios that can return no posts to allow you to more easily display a message like "No posts found :(" that to the end user in an `else` statement — Xhynk, Dec 28 '18 at 23:22

Query inside functions.php does not return posts, while working in template files

1 Answers1