undefined index while update in php issue [PLEASE HELP]

Question

i had a problem in this line, because the error message tell me theres an undefined index:

$strSQL = " UPDATE place SET 
rating_value = '".$_POST["rating_value"]."' 
WHERE place_id = '".$_POST["place_id"]."'
";

pls help me if you have a solution. thanks

Store your `$_POST` variables into a single variale like `$rating_value = $_POST["rating_value"];` — executable, Jan 11 '19 at 09:57
[`var_dump()`](http://php.net/manual/en/function.var-dump.php) helps a lot for debuging — Cid, Jan 11 '19 at 09:58
And please consider that your code is _wide open_ to sql injection attacks. Please learn about the benefits of using "prepared statements" in combination of "parameter binding" to prevent that. — arkascha, Jan 11 '19 at 09:59
@executable excutable what should i write in the update line after i wrote $rating_value = $_POST["rating_value"];? — renaldy kharisma, Jan 11 '19 at 10:02

score -1 · Answer 1 · answered Jan 11 '19 at 10:00

-1

Do you check your variables before do the request like :

if( !empty($_POST["rating_value"]) && !empty($_POST["place_id"]) ) 
{
   // your request
} else {
  echo("error");
}

answered Jan 11 '19 at 10:00

Aym2ric

no. the tutorial i follow is not checking the variable because the tutorial is still using under php 5. so i have to check the variable first? – renaldy kharisma Jan 11 '19 at 10:33
@renaldykharisma you **always** have to check the variables. A rule of thumb is to **never** trust user's inputs. They can enter silly things, on purpose of because... well they are users. – Cid Jan 14 '19 at 08:36

1 Answers1