What's wrong with my code to get last insert id?

Question

This is my code to insert date to database. Everything is fine except I cannot get insert_id.

if ($_SERVER['REQUEST_METHOD'] == 'POST') 
{
    $data_to_store = filter_input_array(INPUT_POST);
    $db = getDbInstance();
    $Stats = $db->insert ('images', $data_to_store);
    $last_id = $db->insert_id();

    if($Stats)
    {
        $_SESSION['success'] = "Record added successfully!";
        header('location: index.php');
        exit();
    }  
}

It shows:

Fatal error: Uncaught Error: Call to undefined method MysqliDb::insert_id() in

My db:

 function getDbInstance() { 
    return new MysqliDb(DB_HOST,DB_USER,DB_PASSWORD,DB_NAME); 
 }

What's wrong?

You should provide more info, about `getDbInstance()` and `insert_id()` — MorganFreeFarm, Jan 17 '19 at 07:54
function getDbInstance() { return new MysqliDb(DB_HOST,DB_USER,DB_PASSWORD,DB_NAME); } — Joe, Jan 17 '19 at 08:10

score 0 · Answer 1 · answered Jan 17 '19 at 07:56

Since PHP's class for mysqli is called mysqli, I'm guessing you're using PHP-MySQLi-Database-Class, whose class name is MysqliDb. This information is important and missing in your post, superb!

If you take a look at the class, you'll see that there is no function called insert_id with 0 parameters. The function you're looking for is called getInsertId. As found in the source.

score -1 · Accepted Answer · answered Jan 17 '19 at 08:46

From what I know MysqliDb does not have a last insert id function like you've tried : insert_id.

There are two ways to go about it.

Change the library to avail something like this PDO::lastInsertId or
You can simply run a select query and fetch the last id in your table.

score -1 · Answer 3 · answered Jan 17 '19 at 09:29

-1

insert_id is a property not a method so it should not have the parenthesis. so it should be

$last_id = $db->insert_id;

not

$last_id = $db->insert_id();

answered Jan 17 '19 at 09:29

Okoro Efe Christopher

52
3

His $db isn't of the mysqli class. – maio290 Jan 17 '19 at 09:38

What's wrong with my code to get last insert id?

3 Answers3