mysql query error with mysql_query() function

Question

if (!empty($name) || !empty($degree) || !empty($college)|| !empty($gender) || !empty($mail) || !empty($phone) || !empty($city)) 
{
    mysql_query($con,
        "INSERT INTO regstration(name,degree,college,gender,mail,phone,city)
        VALUES('$name','$degree','$college','$gender','$mail','$phone','$city')"
    ) or die("error");  
}

The error message is:

mysql_query() expects parameter 1 to be string given resource C://...... line 21

you need to replace || with &&, othervise you will insert empty field or null with error — Zeljka, Feb 04 '19 at 14:00
And apart from all the other comments, nothing will get inserted as the parameters are in the wrong order. — jeroen, Feb 04 '19 at 14:07
mysql_query() expects parameter 1 to be string given resource C://...... line 21 — Dinesh G, Feb 04 '19 at 14:07
Is `regstration` your real table name, or do you mean `registration`? — KHansen, Feb 04 '19 at 14:09
mobile number its an integer format other resources are varchar — Dinesh G, Feb 04 '19 at 14:17
@GMB i m just writing the database its not wriiten on database !! see error mes on my previews comments — Dinesh G, Feb 04 '19 at 14:19
@DineshG Did you try to swap the argument order as I suggested in my post? — dWinder, Feb 04 '19 at 14:32

GMB · Answer 1 · 2019-02-04T14:39:28.963

The first problem with your query is that you have inverted the query string and the connection object in your call to mysql_query.

Also, you commented that mobile number its an integer format other resources are varchar. You should then adapt the insert query to not quote the integer value :

$sql= 
    "INSERT INTO regstration(name,degree,college,gender,mail,phone,city) 
     VALUES('$name','$degree','$college','$gender','$mail',$phone,'$city')";
mysql_query($sql, $con) or die("error : " . mysql_error());

Important remarks :

when a mysql error happens, you can access the error message using mysql_error() (see the above code) ; it is important to have full error messages in order to analyze the error, instead of a generic error mention.
anyone on SO will strongly suggest to use prepared statements and parameterized queries, to protect your code from SQL injection and make your queries more readable and maintainable. Such typo is far much easier to detect when using parameterized queries.
mysql extension is deprecated : you should consider migrating to mysqli or PDO.

dWinder · Answer 2 · 2019-02-04T14:14:49.370

1

Notice that mysql_query first argument is the query and not $con.

It can take $con as second argument:

$query = "INSERT INTO regstration(name,degree,college,gender,mail,phone,city) VALUES('$name','$degree','$college','$gender','$mail','$phone','$city')";
mysql_query($query, $con) or die("error");

And notice also:

This extension was deprecated in PHP 5.5.0

edited Feb 04 '19 at 14:14

answered Feb 04 '19 at 14:09

dWinder

11,597
3
24
39

in u r suggestion the last part error willbe exexuted. its shows error. – Dinesh G Feb 04 '19 at 14:48
no man die error part executed and i will add @GMB code die("error:".mysql_error()) its shows on no database connected – Dinesh G Feb 04 '19 at 14:58
Try without the `$con` as: `mysql_query($query) or die("error : " . mysql_error());` – dWinder Feb 04 '19 at 15:12

mysql query error with mysql_query() function

2 Answers2