images and text not showing in cardview

Question

I am using a card view with a recyclerView.The problem I'm having is that the cards are not displaying the images and the text that is supposed to be displayed, all I get is empty cards. any way I could fix this or am I doing something wrong?

avctivitymain xml

<?xml version="1.0" encoding="utf-8"?>
<LinearLayout
    xmlns:android="http://schemas.android.com/apk/res/android"
    xmlns:tools="http://schemas.android.com/tools"
    xmlns:app="http://schemas.android.com/apk/res-auto"
    android:layout_width="match_parent"
    android:layout_height="match_parent"
    tools:context=".MainActivity"
    android:padding="8dp">

    <android.support.v7.widget.RecyclerView
        android:id="@+id/recyclerview"
        android:layout_width="match_parent"
        android:layout_height="match_parent">

    </android.support.v7.widget.RecyclerView>

</LinearLayout>

cardsport xml

<?xml version="1.0" encoding="utf-8"?>
<android.support.v7.widget.CardView xmlns:android="http://schemas.android.com/apk/res/android"
    android:layout_width="120dp"
    android:layout_height="190dp"
    android:id="@+id/car_lay"
    xmlns:app="http://schemas.android.com/apk/res-auto"
    xmlns:cardview="http://schemas.android.com/tools"
    android:layout_margin="5dp"
   app:cardCornerRadius="4dp">

    <LinearLayout
        android:orientation="vertical"
        android:layout_width="match_parent"
        android:layout_height="match_parent">

        <ImageView
            android:id="@+id/sport_image"
            android:layout_width="match_parent"
            android:layout_height="160dp"
            android:scaleType="centerCrop"/>

        <TextView
            android:id="@+id/sport_title"
            android:layout_width="match_parent"
            android:layout_height="match_parent"
            android:textSize="14sp"
            android:gravity="center"
            android:text="frgrggr"
            android:textColor="#2d2d2d"/>

    </LinearLayout>

</android.support.v7.widget.CardView>

recyclerview adapter class

import java.util.List;

public class Recycler_view extends RecyclerView.Adapter<Recycler_view.myViewHolder>
{

    private Context mContext;
    private List<card> mData;

    public Recycler_view(Context mContext, List<card> mData)
    {
        this.mContext = mContext;
        this.mData = mData;
    }

    @NonNull
    @Override
    public myViewHolder onCreateViewHolder(@NonNull ViewGroup parent, int viewType)
    {

        View v;
        LayoutInflater mflate = LayoutInflater.from(mContext);
        v = mflate.inflate(R.layout.card_sport,parent,false);
        return new myViewHolder(v);
    }

    @Override
    public void onBindViewHolder(@NonNull myViewHolder holder, int position)
    {

        holder.sport_txt.setText(mData.get(position).getType_sport());
        holder.image_view.setImageResource(mData.get(position).getImages());

    }

    @Override
    public int getItemCount()
    {
        return mData.size();
    }

    public static class myViewHolder extends RecyclerView.ViewHolder
    {

        TextView sport_txt;
        ImageView image_view;
        CardView cv;

        public myViewHolder(View itemView)
         {
            super(itemView);

            sport_txt = itemView.findViewById(R.id.sport_title);
            image_view = itemView.findViewById(R.id.sport_image);
            cv = itemView.findViewById(R.id.car_lay);
        }
    }


}

Main activity java class

import android.support.v7.app.AppCompatActivity;
import android.os.Bundle;
import android.support.v7.widget.GridLayoutManager;
import android.support.v7.widget.RecyclerView;

import java.util.ArrayList;
import java.util.List;

public class MainActivity extends AppCompatActivity
{

    List<card> card_sport;

    @Override
    protected void onCreate(Bundle savedInstanceState)
    {
        super.onCreate(savedInstanceState);
        setContentView(R.layout.activity_main);

        card_sport = new ArrayList<>();
        // ADDING DATA TO THE CARD ARRAYLIST
        card_sport.add(new card("soccer",R.drawable.soccer));
        card_sport.add(new card("Cage Fighting",R.drawable.cagef));
        card_sport.add(new card("Cricket",R.drawable.cricket));
        card_sport.add(new card("WaterPolo",R.drawable.polo));
        card_sport.add(new card("Running",R.drawable.runman));
        card_sport.add(new card("Swimming",R.drawable.swim));
        card_sport.add(new card("Rugby",R.drawable.rugby));

        RecyclerView rv = findViewById(R.id.recyclerview);
        Recycler_view re_adapter = new Recycler_view(this, card_sport);
        rv.setLayoutManager(new GridLayoutManager(this,2));
        rv.setAdapter(re_adapter);




    }
}

card java class for getters and setters

package com.example.dalian.cool_jungle;           

public class card                                 
{                                                 
    private String type_sport;                    
    private int images;                           


    public card()                                 
    {                                             

    }                                             



    public card(String type_sport,int images)     
    {                                             
        type_sport= type_sport;                   
        images = images;                          
    }                                             

    public String getType_sport()                 
    {                                             
        return type_sport;                        
    }                                             

    public int getImages()                        
    {                                             
        return images;                            
    }                                             

    public void setType_sport()                   
    {                                             
        type_sport =type_sport;                   
    }                                             

    public void setImages()                       
    {                                             
        images = images;                          
    }                                             




}

log

line 17

line 47

after a taken "this" out my card class it just shows blank cards

in your **cardsport xml** `layout_height` of textview should be wrap_content. — Jakir Hossain, Mar 07 '19 at 09:30

Samrat Hasan · Answer 1 · 2019-03-07T09:47:47.570

0

Your all above code are fine. There will no problem if you made your card object correctly. That may be like:

public class card {
    private String type_sport;
    private int image;

    public card(String type_sport, int image) {
        this.type_sport = type_sport;
        this.image = image;
    }

    public String getType_sport() {
        return type_sport;
    }

    public void setType_sport(String type_sport) {
        this.type_sport = type_sport;
    }

    public int getImages() {
        return image;
    }

    public void setImage(int image) {
        this.image = image;
    }
}

edited Mar 07 '19 at 09:47

answered Mar 07 '19 at 09:34

Samrat Hasan

1
4

did that changes as well, and still crashing – DG fortuin Mar 07 '19 at 14:14
Should I not be using the set methods somewhere.after all they are in the code? – DG fortuin Mar 07 '19 at 14:24
you can avoid set methods. – Samrat Hasan Mar 08 '19 at 02:59
when i take "this" out my code the cards show but blank, I really don't know what's wrong – DG fortuin Mar 08 '19 at 12:52

score 0 · Answer 2 · answered Mar 19 '19 at 10:31

0

You don't need to pass the context in, you can get it from the parent viewgroup. You also don't need to make the view holder a static class, that might help.

answered Mar 19 '19 at 10:31

Jeremiah

41
3

Thanks for that. But figured out what was wrong. My images were too big. – DG fortuin Mar 20 '19 at 16:46

images and text not showing in cardview

2 Answers2

Linked