Getting null uri in onActivityResult after take image capture

Question

I am working on an android app, I need to take image capture from the app and return the capture uri to pass it to api. I am working on oreo 8 . I try many solutions on stackoverflow but none of them work correctly. I get null uri in onActivityResult. I tried to get it directly from the data like this:

uri = data.getData();

also i tried to get the uri from Bitmap like this:

Bitmap photo = (Bitmap) data.getExtras().get("data"); uri = getImageUri(getApplicationContext(), photo);

But still not working.

This is my current code:

button2.setOnClickListener(new View.OnClickListener() {
        @Override
        public void onClick(View view) {
            if(hasStoragePermission(IMAGE_CAPTURE)){
                Intent takePictureIntent = new Intent(MediaStore.ACTION_IMAGE_CAPTURE);
                if (takePictureIntent.resolveActivity(getPackageManager()) != null) {
                    startActivityForResult(takePictureIntent, IMAGE_CAPTURE);
                }
            }
        }
    });
}

@Override
protected void onActivityResult(int requestCode, final int resultCode, Intent data) {
    switch(requestCode) {
        case 0: {
            if (requestCode == PICK_PHOTO_FOR_AVATAR && resultCode == Activity.RESULT_OK) {
                if (data == null) {
                    Toast.makeText(getApplicationContext(), "error selecting file!, Please try again ", Toast.LENGTH_LONG).show();
                    return;
                } else {
                    uri = data.getData();
                }
            }

            break;
        }

        case 1: {
            if (requestCode == IMAGE_CAPTURE && resultCode == Activity.RESULT_OK) {
                if (data == null) {
                    Toast.makeText(getApplicationContext(), "error selecting file!, Please try again ", Toast.LENGTH_LONG).show();
                    return;
                } else {
                        uri = data.getData();
                        /* // Also I try this:
                        Bitmap photo = (Bitmap) data.getExtras().get("data");
                        uri = getImageUri(getApplicationContext(), photo); */
                }
            }
            break;
        }
    }
        super.onActivityResult(requestCode, resultCode, data);
}







public Uri getImageUri(Context inContext, Bitmap inImage) {
    ByteArrayOutputStream bytes = new ByteArrayOutputStream();
    inImage.compress(Bitmap.CompressFormat.JPEG, 100, bytes);
    String path = MediaStore.Images.Media.insertImage(inContext.getContentResolver(), inImage, "Title", null);
    return Uri.parse(path);
}
    private boolean hasStoragePermission(int requestCode) {
    if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.M) {
        if (checkSelfPermission(Manifest.permission.WRITE_EXTERNAL_STORAGE)
                != PackageManager.PERMISSION_GRANTED &&
                checkSelfPermission(Manifest.permission.CAMERA)
                        != PackageManager.PERMISSION_GRANTED) {
            requestPermissions(new String[]{Manifest.permission.WRITE_EXTERNAL_STORAGE}, requestCode);
            requestPermissions(new String[]{Manifest.permission.CAMERA},
                    requestCode);
            return false;
        } else {
            return true;
        }
    } else {
        return true;
    }
}

and this is the run time permission checker:

  private boolean hasStoragePermission(int requestCode) {
    if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.M) {
        if (checkSelfPermission(Manifest.permission.WRITE_EXTERNAL_STORAGE)
                != PackageManager.PERMISSION_GRANTED &&
                checkSelfPermission(Manifest.permission.CAMERA)
                        != PackageManager.PERMISSION_GRANTED) {
            requestPermissions(new String[]{Manifest.permission.WRITE_EXTERNAL_STORAGE}, requestCode);
            requestPermissions(new String[]{Manifest.permission.CAMERA},
                    requestCode);
            return false;
        } else {
            return true;
        }
    } else {
        return true;
    }
}

and this is my permissions:

<uses-permission android:name="android.permission.READ_EXTERNAL_STORAGE"/>
<uses-permission android:name="android.permission.WRITE_EXTERNAL_STORAGE" />
<uses-permission android:name="android.permission.CAMERA" />

What I missed? and Thanks!

[This](https://stackoverflow.com/questions/12952859/capturing-images-with-mediastore-action-image-capture-intent-in-android) one is right approach — M D, Mar 27 '19 at 05:40
Just Follow [Photo Basics](https://developer.android.com/training/camera/photobasics) and you are good to go . — ADM, Mar 27 '19 at 05:57
Refer this link, it might helpful for u https://stackoverflow.com/a/54005662/3946958 — Ravindra Kushwaha, Mar 27 '19 at 06:00

bhagyawant biradar · Accepted Answer · 2019-03-27T06:07:56.617

For android 8.0 or above you have to add create file provider to access photos. to add file provider

add following tag in your manifest file under application tag.

<provider
                android:name="android.support.v4.content.FileProvider"
                android:authorities="com.example.provider"
                android:exported="false"
                android:grantUriPermissions="true"
                tools:replace="android:authorities">
                <meta-data
                    android:name="android.support.FILE_PROVIDER_PATHS"
                    android:resource="@xml/provider_paths"
                    tools:replace="android:resource" />

</provider>

Create provider_paths.xml in xml folder

<?xml version="1.0" encoding="utf-8"?>
<paths>
    <external-path
        name="external_files"
        path="." />
</paths>

Intent to capture image

Intent takePicture = new Intent(MediaStore.ACTION_IMAGE_CAPTURE);
                    // Create the File where the photo should go
                    File photoFile = null;
                    try {
                        photoFile = createImageFile();
                    } catch (IOException ex) {
                        // Error occurred while creating the File

                    }
                    // Continue only if the File was successfully created
                    if (photoFile != null) {
                        if ((Build.VERSION.SDK_INT > Build.VERSION_CODES.KITKAT)) {
                            photoURI = FileProvider.getUriForFile(getContext(),
                                    "com.example.provider",
                                    photoFile);
                            //FAApplication.setPhotoUri(photoURI);
                        } else {
                            photoURI = Uri.fromFile(photoFile);
                        }

                        takePicture.putExtra(MediaStore.EXTRA_OUTPUT, photoURI);
                        startActivityForResult(takePicture, 101);

And in onActivity result

if (requestCode == 101) {
                    Uri contentUri = FileProvider.getUriForFile(getContext(), "com.example.provider", new File(mCurrentPhotoPath)); //You wll get the proper image uri here.
                }

createImageFile()

private File createImageFile() throws IOException {
        // Create an image file name
        String timeStamp = new SimpleDateFormat("yyyyMMdd_HHmmss").format(new Date());
        String imageFileName = "JPEG_" + timeStamp + "_";
        File storageDir = Environment.getExternalStoragePublicDirectory(Environment.DIRECTORY_PICTURES);


        /*File file = new File(getContext().getExternalFilesDir(Environment.DIRECTORY_PICTURES)
                + File.separator
                + imageFileName);
        if (file.getParentFile().exists() || file.getParentFile().mkdirs()) {
            mCurrentPhotoPath = file.getAbsolutePath();
        }*/


        File file = File.createTempFile(
                imageFileName,   //prefix
                ".jpg",          //suffix
                storageDir       //directory
        );

        // Save a file: path for use with ACTION_VIEW intents

        return file;
    }

Thankyou for your help! I am trying now, but I want to ask about the get uri line in the onActionResult, you put: mCurrentPhotoPath what should this value be?? because you comment lines which contain it. — Haya Akkad, Mar 27 '19 at 06:26
Put this line before return file; in createImageFile() method mCurrentPhotoPath = file.getAbsolutePath(); — bhagyawant biradar, Mar 27 '19 at 06:27
Have asked for storage permission? Storage permission should be enabled. — bhagyawant biradar, Mar 27 '19 at 06:37
Let us [continue this discussion in chat](https://chat.stackoverflow.com/rooms/190747/discussion-between-bhagyawant-biradar-and-haya-akkad). — bhagyawant biradar, Mar 27 '19 at 06:40
@bhagyawantbiradar your solution is working fine in all devices except Xiaomi Mi A2, In onActivityResult mCurrentPhotoPath becomes null in this device, Please help — Divy Soni, Jan 14 '20 at 10:56

Getting null uri in onActivityResult after take image capture

This is my current code:

and this is the run time permission checker:

and this is my permissions:

1 Answers1