static variable position of singleton

Question

I have a question with singlton.

Where should I declare the static member of the singleton class?

why not working like this

class singleton{

  private:

  static singleton & m_singleton;

  public:

  static singleton& get_instance{

          return m_singleton;
  }

}

but I have to be like this

class singleton{

  public:

  static singleton& get_instance{

     static singleton & m_singleton;

          return m_singleton;
  }

}

What's the differnece?

I know there is another way to use pointer, but now I am only talking about the case to use an object.

Also another questions, what's the pros/cons to use pointer and reference for singleton ?

Thanks so much!

More info here: http://stackoverflow.com/questions/1008019/c-singleton-design-pattern/1008289#1008289 — Martin York, Apr 05 '11 at 23:20

shoosh · Accepted Answer · 2011-04-05T23:08:49.663

In the first case, the singleton is constructed (constructor called) when the program initializes, before main() is called. In this case you will also need to define the static variable somewhere in your cpp file.

In the second case the singleton is constructed when the function is first called. Mind you that this implementation is not thread safe since static variable initialization in functions is not thread safe. If two threads call this function for what appears to be the first time, there is a small chance you'll end up with two singletons.

Also notice you have a bug in the second one. You cannot define a reference without an initalization. This

static SomeClass &var;

Does not compile. You need to remove the reference to create an actual instance of the class, not a reference, and then return a reference to it.

If in the second example you define the static variable as a pointer you can avoid the threading problem I mentioned by carefully initializing the pointer. Read more about it in this class article (that talks about Java but the core issue is the same)

+1: Generally agree. But If you change it to a pointer you run into the problem of destroying the singleton. Its a lot easier just to add locks around the creation of the singleton on platforms that need it (ie not gcc). — Martin York, Apr 05 '11 at 23:19

static variable position of singleton

1 Answers1