Exact file extension match with GetFiles()?

Question

I'd like to retrieve a list of files whose extensions match a specified string exactly.

DirectoryInfo di = new DirectoryInfo(someValidPath);
List<FileInfo> myFiles = new List<FileInfo>();
foreach (FileInfo fi in di.GetFiles("*.txt"))
{
    myFiles.Add(fi);
}

I get the files with extension *.txt but I also get files with the extension *.txtx, so what I've coded amounts to getting the files whose extension starts with txt.

This isn't what I want. Do I need to grab all of the filenames and do a regular expression match to "\\.txt$" (I think), or test each filename string with .EndsWith(".txt"), etc., to accomplish this?

Thanks!

Yes, you do. Is it so hard, and why do you need regulare expressions? — , Apr 06 '11 at 21:19
Watch out, *every* answer forgets that Windows file names are case insensitive. You can get .TXT as well. Casing rules for file names are a bit nasty, you might want to check the string length. — Hans Passant, Apr 06 '11 at 22:06
@Hans: Good point. Does Fredrik's answer handle the case insensitivity issue? — John, Apr 07 '11 at 02:26
Erm, it's better. As I said, nasty, the file system keeps its own casing rules. Fredrik's code works if it is just .txt — Hans Passant, Apr 07 '11 at 02:40

score 4 · Accepted Answer · answered Apr 06 '11 at 21:25

Somewhat of a workaround, but you can filter out exact matches with the Where extesion method:

foreach (FileInfo fi in di.GetFiles("*.txt")
    .Where(fi => string.Compare(".txt", fi.Extension, StringComparison.OrdinalIgnoreCase) == 0))
{
   myFiles.Add(fi);
}

Note that this will make a case insensitive matching of the extension.

Chuck Savage · Answer 2 · 2011-04-06T21:58:00.383

3

Using the AddRange feature of lists instead of doing the foreach loop and calling Add for each item returned by the expression below (which I save into the variable list).

var list = di.GetFiles("*.txt").Where(f => f.Extension == ".txt");
myFiles.AddRange(list);

I'm presuming you were just showing us a snippet of your code and myFiles already had values in it, if not, you could do instead.

List<FileInfo> myFiles = di.GetFiles("*.txt").Where(f => f.Extension == ".txt").ToList();

edited Apr 06 '11 at 21:58

answered Apr 06 '11 at 21:51

Chuck Savage

11,775
6
49
69

Edited and gave a bit more of an example. – Chuck Savage Apr 06 '11 at 21:58

score 2 · Answer 3 · edited Apr 06 '11 at 21:46

2

Regex might be overkill. Use the extension on FileInfo.

foreach (FileInfo fi in di.GetFiles("*.txt").Where(f => f.Extension == ".txt"))
{
     myFiles.Add(fi);
}

edited Apr 06 '11 at 21:46

Chandu

81,493
19
133
134

answered Apr 06 '11 at 21:23

vcsjones

138,677
31
291
286

1

instead of foreach loop, you can do `myFiles.AddRange( the expression )` – Chuck Savage Apr 06 '11 at 21:28
@Chuck Savage: is "the expression" the part in the `foreach` loop following `in`? – John Apr 06 '11 at 21:38

score 1 · Answer 4 · answered Apr 06 '11 at 21:22

1

Try this:

DirectoryInfo di = new DirectoryInfo(someValidPath); 
List<FileInfo> myFiles =  
    (
        from file in di.GetFiles("*.txt")
        where file.Extension == ".txt"
        select file
    ).ToList();

answered Apr 06 '11 at 21:22

Chandu

81,493
19
133
134

score 1 · Answer 5 · answered Apr 06 '11 at 21:26

1

DirectoryInfo di = new DirectoryInfo(someValidPath);
List<FileInfo> myFiles = new List<FileInfo>();
foreach (FileInfo fi in di.GetFiles("*.txt"))
{
   if (fi.Extension == ".txt")
      myFiles.Add(fi);
}

answered Apr 06 '11 at 21:26

Richard Schneider

34,944
9
57
73

score 0 · Answer 6 · answered Nov 21 '13 at 19:40

I had a user-supplied pattern so many of the other answers didn't suit me. I ended up with this more general purpose solution:

public string[] GetFiles(string path, string pattern)
{
    bool lastWildIsHook = false;
    if(pattern.EndsWith("?"))
    {
        pattern = pattern.Substring(0, pattern.Length - 1);
        lastWildIsHook = true;
    }
    var lastWildIndex = Math.Max(pattern.LastIndexOf("*"), pattern.LastIndexOf("?"));
    var endsWith = pattern.Length > lastWildIndex ? pattern.Substring(lastWildIndex + 1) : pattern;
    if(!lastWildIsHook)
        return Directory.GetFiles(path, pattern).Where(p => p.EndsWith(endsWith)).ToArray();
    else
        return Directory.GetFiles(path, pattern).Where(p => p.EndsWith(endsWith) || p.Substring(0, p.Length - 1).EndsWith(endsWith)).ToArray();
}

score 0 · Answer 7 · answered Apr 06 '11 at 21:27

0

Couldn't you just add an if and check the last four characters of the filename?

answered Apr 06 '11 at 21:27

MPękalski

6,873
4
26
36

score 0 · Answer 8 · answered Apr 06 '11 at 21:44

If you are using C# 2.0 Isn't easier ?

string fileExtensionFilter = "*.txt";
            DirectoryInfo di = new DirectoryInfo(Environment.GetFolderPath(Environment.SpecialFolder.MyDocuments));
            List<FileInfo> myFiles = new List<FileInfo>();
            foreach (FileInfo fi in di.GetFiles(fileExtensionFilter))
            {
                if (fi.Extension == fileExtensionFilter.Substring(1)) myFiles.Add(fi);
            }

Exact file extension match with GetFiles()?

8 Answers8

Linked

Related