React setState proper usage

Question

So I read a lot that setState calls are batched and are async, and that one should use the updater function to update state when any value is read from the state in setState.

class App extends React.Component {
  state = { count: 1 }
  handleClick = () => {
    this.setState({ count: this.state.count + 1 }) 
  }

  render() {
    return (
      <div>
        <div>{this.state.count}</div>
        <button onClick={this.handleClick}>Click</button>
      </div>
    )
  }
}

Considering above code ONLY, can someone explain what might go wrong in this case by not using the updater pattern of setState? Even if setState is called later, this.state will always refer to previous state, which is what we want here.

PS: I know that calling setState multiple times one after the other will cause errors in this kind of scenario because they are async, but that's not the case here.

Refer to [48563650](https://stackoverflow.com/questions/48563650/does-react-keep-the-order-for-state-updates/48610973#48610973) question. — Radonirina Maminiaina, May 07 '19 at 07:41

punjira · Answer 1 · 2019-05-07T08:43:45.900

One reason that you should not do this is setStates async behavior. for example if you had two setStates in a single function you wont get the desired output. consider this:

handleClick(){
    this.setState({
        count : this.state.count + 1
    })
    this.setState({
        count : this.state.count + 1
    })
}

If you log the this.state.count now its value will be incremented only by one, but if you do it like this:

handleClick(){
    this.setState((prevState)=>({
        amount : prevState.count + 1
    }))
    this.setState((prevState)=>({
        amount : prevState.count + 1
    }))
}

you will get correct output.

also

the DOM is not updated as soon as setState is invoked. Rather, React batches multiple updates into one update and then renders the DOM. You may receive outdated values while querying the state object How to NOT React

EDIT: i just saw the last paragraph of your question and seems like my answer is exactly what you said you already know! well in that case i think its just respecting the good practices.

React setState proper usage

1 Answers1