Unable to return value from function

Question

I'm getting undefined on return value from the function

function checkAveStorage(path) {
    console.log("path " + path);
    disk.check(path, function(err, info) {
    if (err) {
        console.log(err);
        return -1;
    } else {
        console.log("info " + info.available);
        return ((info.available / info.total) * 100).toFixed(2); 
    }      
    });
}



app.get("/sysinfo", (req, res, next) => {   
     var storage = checkAveStorage('/mnt/usb');
     console.log(storage);
})

undefined value appear in console.

Possible duplicate of [How to return value from an asynchronous callback function?](https://stackoverflow.com/questions/6847697/how-to-return-value-from-an-asynchronous-callback-function) — eol, Jun 12 '19 at 10:22

score 0 · Answer 1 · answered Jun 12 '19 at 10:27

0

You are using callback so you must :

app.get("/sysinfo", (req, res, next) => {   
   checkAveStorage('/mnt/usb').then((storage)=>{
   console.log(storage)

})

answered Jun 12 '19 at 10:27

Le Quang

515
4
10

mabc224 · Accepted Answer · 2019-06-12T10:43:30.257

You are using callback which cannot return value, but you can use it inside that call back only. Other options are use promise or async/await.

function checkAveStorage (path) {
    console.log('path ' + path)
    return new Promise((resolve, reject) => {
        disk.check(path, function (err, info) {
            if (err) {
                console.log(err)
                reject(-1)
            } else {
                console.log('info ' + info.available)
                resolve(((info.available / info.total) * 100).toFixed(2))
            }
        })
    })
}

app.get('/sysinfo', (req, res, next) => {
    checkAveStorage('/mnt/usb').then((storage => {
        console.log(storage)
    }), (err) => {
        console.log(err)
    })
})

Another way with async/await

async function checkAveStorage(path) {
    try{
      const info = await disk.check(path);
      return ((info.available / info.total) * 100).toFixed(2);
    } catch(err){
      console.log(err);
      return -1;
    }
}



app.get("/sysinfo", async (req, res, next) => {   
     var storage = await checkAveStorage('/mnt/usb');
     console.log(storage);
})

Unable to return value from function

2 Answers2