Why does my struct lose the string value even with references?

Question

struct Word {

    string wordName; //loses its value
    vector<string> contents; //irrelevant for the question
    int numContents = 0; //maintains its value

};

vector<Word*> wordMsgs;

int main()
{

vector<string> result;
result.push_back("wordName");
result.push_back("shouldEnterIf");

Word curr;
        //New Word
        if (result[1] != "") {
            Word w;
            w.numContents = 10; //just a testing #, suppose to represent size of vector
            wordMsgs.push_back(&w);


            w.wordName = result[0]; //name of Word


            //here w.wordName and (*wordMsgs[0]).wordName display the same string; result[0] 
            curr = w;
        }
        //here curr.wordName displays result[0] but (*wordMsgs[0]).wordName doesn't. However, (*wordMsgs[0]).numContents returns 10 as expected
}
}

So I have a vector of struct references, assuming the push_back() method for vectors only pushes a copy to the end of the vector. I create an instance of my Word struct and put that reference into my vector, wordMsgs. I then edit the struct it is pointing too and then my string variable is lost upon leaving the if statement! However, my int variable never loses its value. I don't understand because I used pointers (and I'm in C++ so I thought strings were a-okay) and I wouldn't think this is a local variable issue...

[Your code example doesn't even compile](http://coliru.stacked-crooked.com/a/1e4f93a244a7cda5). Post a [mcve] reproducing the problem as required here please! — πάντα ῥεῖ, Jun 13 '19 at 19:09
Which `Word` do you think `&w` points to, after `w` has ceased to exist? — molbdnilo, Jun 13 '19 at 19:12
`//irrelevant for the question`. so don't include it in the question. — Jarod42, Jun 13 '19 at 19:13
Instead of extending your exmaple code, you should reduce it to the part which really relates to your problem you can't solve... — Klaus, Jun 13 '19 at 19:14
I suggest you stop using raw pointers and don't use `new` unless you positively know you need it and understand object lifetimes and manual memory management. — Blastfurnace, Jun 13 '19 at 19:16
Some reading on `new`: [Why should C++ programmers minimize use of 'new'?](https://stackoverflow.com/questions/6500313/why-should-c-programmers-minimize-use-of-new) — user4581301, Jun 13 '19 at 19:19

score 1 · Answer 1 · answered Jun 13 '19 at 19:14

1

The variable w in:

    if (...) {
        Word w;
        wordMsgs.push_back(&w);
        ...
    }

Is allocated on the stack inside the scope of the if statement.

You are then adding its address to your vector of pointers.

Once outside the if statement, this variable is deallocated and the value at that address is no longer "solid", so you essentially have a "garbage address" in that vector.

From here onward, the behavior of your program is mostly unpredictable...

answered Jun 13 '19 at 19:14

goodvibration

5,980
4
28
61

_"From here onward, the behavior of your program is mostly unpredictable..."_ Well, that's called _undefined behavior_. Thus we already have a standard definition of that situation. – πάντα ῥεῖ Jun 13 '19 at 19:19
Recommend adding a solution like changing `vector wordMsgs;` to `vector wordMsgs;` and discarding the pointer completely – user4581301 Jun 13 '19 at 19:22

score 0 · Answer 2 · answered Jun 13 '19 at 19:22

Here is a minimal example of what is going wrong in your code:

#include <string>
#include <vector>
#include <iostream>

int main() {
   std::vector<string*> words;     // why pointers?

   if (true) {                    // scope starts here
       std::string word = "muh";   
       words.push_back(&word);    // dont do that !!
   }                              // scope ends here

   std::cout << *words.back(); 
}

By the time you access the string by dereferencing the pointer, the string is long gone, because word is destroyed when it goes outof scope. Dereferencing the pointer is undefined behaviour. You shouldnt have raw pointers in the vector when you dont need to. You probably wanted something like this:

#include <string>
#include <vector>
#include <iostream>

int main() {
   std::vector<string> words;

   if (true) {               
       std::string word = "muh";   
       words.push_back(word);      // vector stores a copy ! and manages lifetime of its elements
   }                         

   std::cout << words.back(); 
}

score 0 · Answer 3 · answered Jun 13 '19 at 19:31

You have a vector of pointers, not refrences. When you push back the adress of the locally defined struct Wors w by using &w you will lose that data directly when you go out of the if statement. You need to allocate and deallocate memory for the vector. Best to either just push objects in the vector or use a smart pointer.

Why does my struct lose the string value even with references?

3 Answers3