Received `false` for a non-boolean attribute `loading`

Question

I've created a custom button component based on Material-UI's Button component, so I can overlay a loading circle whenever an action is pending. However, React complains with the following:

Warning: Received false for a non-boolean attribute loading. If you want to write it to the DOM, pass a string instead: loading="false" or loading={value.toString()}.

Here's what my component looks like. Thanks in advance!

import * as React from 'react'
import { ButtonProps } from '@material-ui/core/Button'
import { Button, CircularProgress } from '@material-ui/core'

interface IProps extends ButtonProps {
    loading: boolean
}

export const LoadingButton = (props: IProps) => {
    const { disabled, loading } = props
    return (
        <div className='button-container'>
            <Button {...props} disabled={disabled == true || loading == true}/>
            {loading == true && (
                <CircularProgress size={24} className='button-progress' />
            )}
        </div>
    )
}

This may help you - https://stackoverflow.com/questions/44375759/how-should-i-declare-a-stateless-functional-component-with-typescript-in-react — ravibagul91, Aug 08 '19 at 05:58
This doesn't address my issue, which is a JavaScript error (not a TypScript error) — cameraguy258, Aug 08 '19 at 06:15

frogatto · Accepted Answer · 2019-08-08T06:59:48.090

24

You shouldn't pass your custom props down to the Button.

Replace

const { disabled, loading } = props

with

const { disabled, loading, ...rest } = props

and then

<Button {...rest} disabled={disabled || loading}/>

edited Aug 08 '19 at 06:59

answered Aug 08 '19 at 06:52

frogatto

28,539
11
83
129

Jørgen · Answer 2 · 2019-08-08T07:11:39.487

Your problem is that you are passing all your props to the Button component. Remove {...props} from <Button /> and declare the attributes separately.

Looking at the documentation, you can see that loading it is not an attribute on the Button component, but the spread operator ... still add it.

<div className="button-container">
      <Button disabled={disabled === true || loading === true} />
      {loading === true && <CircularProgress size={24} className="button-progress" />}
    </div>
  )

Also, as a side note, I recommend that you use the === identity operator instead of the == equality operator. See this post Which equals operator (== vs ===) should be used in JavaScript comparisons?

This wouldn't work in the case where I pass, for example, `onClick: () => void` to the ``. The underlying ` — cameraguy258, Aug 08 '19 at 07:21

Received `false` for a non-boolean attribute `loading`

2 Answers2