35

So I have a model that includes:

class Place(models.Model):
    ....
    created_by = models.ForeignKey(User)

My view is like so:

class PlaceFormView(CreateView):
    form_class = PlaceForm

    @method_decorator(login_required)
    def dispatch(self, *args, **kwargs):
        return super(PlaceFormView, self).dispatch(*args, **kwargs)

Is there a way for me to access request.user and set created_by to that user? I've looked through the docs, but can't seem to find any hints toward this.

`

Brian
  • 931
  • 2
  • 9
  • 13

3 Answers3

35

How about overriding form_valid which does the form saving? Save it yourself, do whatever you want to it, then do the redirect.

class PlaceFormView(CreateView):
    form_class = PlaceForm

    @method_decorator(login_required)
    def dispatch(self, *args, **kwargs):
        return super(PlaceFormView, self).dispatch(*args, **kwargs)

    def form_valid(self, form):
        obj = form.save(commit=False)
        obj.created_by = self.request.user
        obj.save()        
        return http.HttpResponseRedirect(self.get_success_url())
Yuji 'Tomita' Tomita
  • 115,817
  • 29
  • 282
  • 245
  • 1
    Thanks! This works, except for the redirect. I get the error: "No URL to redirect to. Either provide a url or define a get_absolute_url method on the Model." However, I do have a get_absolute_url() set on the model, and when I first got this view working (with created_by a select box on form) it redirected properly. Trying to figure this out now. Any ideas? – Brian Apr 26 '11 at 04:32
  • 1
    Yes, it appears get_absolute_url is pulled from self.object - so in your code, set `self.object = obj` in `form_valid` – Yuji 'Tomita' Tomita Apr 26 '11 at 04:50
  • Is it possible to do this without extending the CreateView? – john2x Sep 12 '11 at 03:49
  • 1
    Shouldn't we rather do at the end of form_valid: return super(PlaceFormView, self).form_valid(form) Otherwise the default form_valid is never called... – Marc Mar 28 '16 at 06:36
  • @Marc the "default" form_valid does the same, you can check it easily at ccbv.co.uk, it justs saves the object and redirects. – José Tomás Tocino Mar 05 '17 at 19:39
  • Awsome answer. Works like a charm ! – marlonjd May 24 '20 at 10:27
23

I know that this is old, but for other people with this problem:

There is an even simpler way - since saving a form multiple times will always use the same model instance, you can also do:

def form_valid(self, form):
    obj = form.save(commit=False)
    obj.created_by = self.request.user
    return super(PlaceFormView, self).form_valid(form)

That way, you get all the benefits of the super call - it's trivial to see that you're really only adding those two lines of code, and you don't have to repeat yourself by replicating the redirect logic.

ralokt
  • 1,855
  • 3
  • 17
  • 19
5

An alternate way to do this is to pass the user through overwriting the get_initial() method in the CreateView, and modify save method in the PlaceForm class to save the user:

class PlaceForm(forms.ModelForm):
    ...
    ...
    ...

    def __init__(self, *args, **kwargs):
        self.created_by = kwargs['initial']['created_by']
        super(PlaceForm, self).__init__(*args, **kwargs)

    def save(self, commit=True):
        obj = super(PlaceForm, self).save(False)
        obj.created_by = self.created_by
        commit and obj.save()
        return obj

class PlaceFormView(CreateView):
    ...
    ...
    form_class = PlaceForm

    def get_initial(self):
        self.initial.update({ 'created_by': self.request.user })
        return self.initial

This way the saving logic is still encapsulated within the form class.

Bryan
  • 3,220
  • 3
  • 26
  • 31