iOS 13 UIBarButtonItem not clickable and overlapping UINavigationBars when using UISearchController

Question

I got a navigation bar containing some UIBarButtonItem buttons and a UISearchBar hooked up like this

var searchController: UISearchController!

override func viewDidLoad() {
    super.viewDidLoad()

    title = "Test"

    tableView.delegate = self
    tableView.dataSource = self

    searchController = UISearchController(searchResultsController: nil)
    navigationItem.searchController = searchController

    // This leads to the bug
    searchController.hidesNavigationBarDuringPresentation = false

    navigationItem.leftBarButtonItem = UIBarButtonItem(barButtonSystemItem: .action, target: self, action: #selector(leftTapped))
    navigationItem.rightBarButtonItem = UIBarButtonItem(barButtonSystemItem: .action, target: self, action: #selector(rightTapped))
}

Scenario: I tap into the search bar and tap cancel afterwards.

Issue 1: The bar buttons are not reacting to touch except when I touch the outer most pixels of the screen (only possible with the simulator and mouse clicks).
Issue 2: The navigation items are overlapping when I push another view controller.

When I use hidesNavigationBarDuringPresentation = true it's working like expected.

The issue appears on notched and non-notched iPhones iOS 13.0 and 13.1 using Xcode 11.0 and 11.1.

Here's the whole test project: https://github.com/fl034/HidesNavigationBarDuringPresentationTest

I've filed a radar (and you should too), but maybe some of you guys have already a workaround for it?

Update 1: Bug is still there in iOS 13.1.1

Update 2: Bug is fixed in iOS 13.2 beta (thanks @Ben Gomm)

I have noticed this as well - had to make `hidesNavigationBarDuringPresentation` true to avoid this bug, but that's not the appearance I want. I presume it is a bug. With large titles on, cancelling the search bar seems to make a second large title appear that doesn't scroll with the rest of the scroll view. — Chris, Sep 27 '19 at 13:47
Very nice demo but you should eliminate everything that isn't necessary for demonstration of the bug. You don't need the tab bar controller. You don't need the bar button items! Just tapping on a table row to navigate is enough to show that the nav bar has been damaged. — matt, Sep 27 '19 at 15:31
Agreed. Except that I need the bar buttons to demonstrate that the bar buttons aren't clickable anymore. — heyfrank, Sep 27 '19 at 15:56
@Noah-1 Not really, except setting `searchController.hidesNavigationBarDuringPresentation = true` — heyfrank, Sep 29 '19 at 16:03
Found same issue today when upgrade to iOS 13 and Xcode 11. Your solution fix my issue too, thanks:) — Zhou Haibo, Oct 21 '19 at 05:50
I am facing kind of the same issue. My code is working when I build and run with XCode. But when I archive and push to Testflight, the button is not clickable anymore... — Funnycuni, Oct 23 '19 at 09:12
@Funnycuni do you archive using the UI? Then it should be no difference. If you're using command line or fastlane then check the command line tools version in Xcode settings > locations or using terminal with the `xcode-select` command. You should archive with the same version you're developing to avoid surprises like this. — heyfrank, Oct 23 '19 at 09:46
You could open your own question on SO and refer to this question if it's the same bug. — heyfrank, Oct 23 '19 at 11:27
I am having the same issue but I can't do hidesNavigationBarDuringPresentation to true because I still need to show bar buttons when UISearchBar is the first responder — Usuf, Oct 24 '19 at 21:28

matt · Answer 1 · 2019-09-29T00:35:03.487

The view debugger reveals what's going on with this bug. The contents of the navigation bar are being copied. Here's what the navigation bar looks like before you show the search:

And here's what it looks like afterwards:

The two replicant views and the extra UILabel are the problem. I don't know what they're doing there and I can't find a way to remove them.

EDIT By the way, I think some of Apple's apps display the same bug. It's easier to see if you have large titles, because then you can see the large title and the extra label at the same time:

score 6 · Answer 2 · answered Oct 28 '19 at 12:31

6

I'm now using this workaround as I want most of my users have the navigation bar visible while search is active (for several app-ux-specific reasons).

var isIosVersionWithNavigationBarBug: Bool {
    if #available(iOS 13.2, *) {
        return false
    }
    if #available(iOS 13.0, *) {
        return true
    }        
    return false
}

In my search controller I use it like this

mySearchController.hidesNavigationBarDuringPresentation = isIosVersionWithNavigationBarBug

So if iOS 13.2 is being released and the user updates to it, the workaround is not being applied anymore.

answered Oct 28 '19 at 12:31

heyfrank

5,291
3
32
46

@n8gray this is not true, #available is absolutely a runtime check. Source: We use this in apps that over 20million users have downloaded and never had a single issue. It even says in the link your provided that: "If you just want to check if the users is running at least a specific version" to use #available – simonthumper Sep 04 '20 at 09:44
@simonthumper: Right you are. Not sure what I was thinking there. It's a shame that Swift has chosen to use the `#` character to tag both values that evaluate at compile time (like `#if`) *and* runtime checks like `#available`. C was better in that regard. – n8gray Sep 04 '20 at 17:13
It’s a strange one definitely!! There have been some odd decisions made, but overall I’m a fan! Just wanted to make sure that others who found this didn’t end up confused :) – simonthumper Sep 05 '20 at 20:33

score 3 · Answer 3 · answered Oct 03 '19 at 13:10

3

This appears to be fixed in iOS 13.2 beta, I tested the example project above using Xcode 11.2 beta (11B41).

answered Oct 03 '19 at 13:10

Ben Gomm

91
1
2

score 0 · Answer 4 · answered Oct 22 '19 at 00:04

0

Not proud of it but I got it working for now with this hack.

override func viewWillDisappear(_ animated: Bool) {
    super.viewWillDisappear(animated)
    let viewsToRemove = self.navigationController?.navigationBar.subviews.flatMap({ (view) in
        view.subviews.filter { type(of: $0) == UILabel.self }
    })
    viewsToRemove?.forEach { $0.removeFromSuperview() }
}

answered Oct 22 '19 at 00:04

senthilvkumar

1

This fixes only the doubled title labels. Sill can't click on my bar button items after having activated the search once. – heyfrank Oct 28 '19 at 12:24

iOS 13 UIBarButtonItem not clickable and overlapping UINavigationBars when using UISearchController

4 Answers4

Linked