javax validation does not validate notNull

Question

I have a springBoot 2.1.9.RELEASE application that uses Spring Data for Couchbase

I have this object

@Data
@AllArgsConstructor
@NoArgsConstructor
public class Hostel<T> {

    @NotNull
    @JsonProperty("_location")
    private T location;

}

and this other one

@Document
@Data
@AllArgsConstructor
@NoArgsConstructor
@EqualsAndHashCode(of = { "id" })
@Builder
public class HTMDoc {

    @Id
    private String id;
    @NotNull
    @Field
    private Hostel hostel;

}

on the service

public HTMDoc create(@Valid HTMDoc doc) {
    return repository.save(doc);
}

on the test

service.create(new HTMDoc());

but when I save I got this error instead of the validation NotNull in the hostel field

 org.springframework.data.mapping.MappingException: An ID property is needed, but not found/could not be generated on this entity.

The id field does not have _@NotNull, why it should validate it? I would put it there and I would consider to apply the _@GeneratedValue too (if the id is not provided in the create call...) (hm how to write java annotations here so to avoid stackoverflow engine recoginizing it as user mention?) — m4gic, Oct 07 '19 at 08:01
Yes, and that means that it will be checked whether the HTMDoc.hostel is null or not. But you have told nothing to the validation engine about the other field. — m4gic, Oct 07 '19 at 08:08
Which @NotNull annotation are you using? Show the full package. — George, Oct 10 '19 at 13:21

score 8 · Accepted Answer · answered Oct 10 '19 at 15:12

You need to use the @org.springframework.validation.annotation.Validated annotation over your service class to enable validation.

@Validated
@Service
public class DocService {
  public HTMDoc create(@Valid HTMDoc doc) {
    return repository.save(doc);
  }
}

score 1 · Answer 2 · answered Oct 07 '19 at 08:09

Add the following annotation to the id and give it a try:

@Id
@GeneratedValue(strategy = GenerationStrategy.UNIQUE)
private String id;

More info about @GeneratedValue annotation can be found in this great answer: Spring GeneratedValue annotation usage

score 0 · Answer 3 · answered Oct 09 '19 at 18:24

0

Put the annotation on the getter.

Maybe the validation is not supported in private fields.

answered Oct 09 '19 at 18:24

AlexS

5,295
3
38
54

score 0 · Answer 4 · answered Oct 11 '19 at 16:58

0

@Data
@AllArgsConstructor
@NoArgsConstructor
public class Hostel<T> {
    @Id
    private Long id;
    @NotNull
    @JsonProperty("_location")
    private T location;

}

Using @Id on any property is mandatory in Model classes.

answered Oct 11 '19 at 16:58

Raghunath

29
4

TanvirChowdhury · Answer 5 · 2020-06-07T15:28:36.577

please add the following syntax on your id field

@Data
@AllArgsConstructor
@NoArgsConstructor
public class Hostel<T> {
    @Id
    @GeneratedValue(strategy = GenerationType.IDENTITY)
    @Column(name = "id", nullable = false, updatable = false)
    private Long id;

    @NotNull
    @JsonProperty("_location")
    private T location;

}

also use the validate annotation in your service class.

@Validated
@Service
public class DocService {
  public HTMDoc create(@Valid HTMDoc doc) {
    return repository.save(doc);
  }
}

score 0 · Answer 6 · answered Oct 16 '19 at 07:07

You need to use the @Validated annotation in your classes to inform the spring boot that these classes are should be validated by javax validations.

@Validated
@Component
public class Phone {
 //Your logic
}

javax validation does not validate notNull

6 Answers6