My progam crashes when using custom dialog

Question

I am trying to make a custom dialog but am experiencing a problem. My app crashes when I push the button which shows the dialog.

Here is my code:

public class Cartas extends AppCompatActivity {

    Dialog myDialog;
    Button senmacho;
    Button cerrar;

    @Override
    protected void onCreate(Bundle savedInstanceState) {
        super.onCreate(savedInstanceState);
        setContentView(R.layout.activity_cartas);

        senmacho = (Button) findViewById(R.id.senmacho);
        senmacho.setOnClickListener(new View.OnClickListener() {
            @Override
            public void onClick(View view) {
                senamacho();
            }
        });
    }

    public void senamacho(){
        myDialog = new Dialog(Cartas.this);
        myDialog.setContentView(R.layout.macho);
        myDialog.requestWindowFeature(Window.FEATURE_NO_TITLE);
        cerrar = (Button) findViewById(R.id.cerrar);
        cerrar.setOnClickListener(new View.OnClickListener() {
            @Override
            public void onClick(View view) {
                myDialog.cancel();
            }
        });
        myDialog.show();
    }
}

Adding the output from the console when the crash occurs will help. The stack trace will show where in your code the crash is occuring. — Gene Z. Ragan, Oct 15 '19 at 20:30
the problem is here `cerrar = (Button) findViewById(R.id.cerrar);` the cerrar button is declare in your Activity layout while it being use in your custom dialog layout. So if your button is in `R.layout.macho` already just change it to `Button cerrar = (Button) myDialog.findViewById(R.id.cerrar);` — L2_Paver, Oct 16 '19 at 01:24

score 0 · Accepted Answer · answered Oct 15 '19 at 20:57

0

Changing the line cerrar = (Button) findViewById(R.id.cerrar); into cerrar = (Button) myDialog.findViewById(R.id.cerrar); or into cerrar = myDialog.findViewById(R.id.cerrar); might solve this issue . . .

answered Oct 15 '19 at 20:57

elyar abad

771
1
8
27

score 0 · Answer 2 · answered Oct 16 '19 at 05:57

There is a very basic error. You should follow the code below.

Instead: of this:

public void senamacho(){
    myDialog = new Dialog(Cartas.this);
    myDialog.setContentView(R.layout.macho);
    myDialog.requestWindowFeature(Window.FEATURE_NO_TITLE);
    cerrar = (Button) findViewById(R.id.cerrar);
    cerrar.setOnClickListener(new View.OnClickListener() {
        @Override
        public void onClick(View view) {
            myDialog.cancel();
        }
    });
    myDialog.show();
}

Use This

public void senamacho(){
    myDialog = new Dialog(Cartas.this);
    myDialog.setContentView(R.layout.macho);
    myDialog.requestWindowFeature(Window.FEATURE_NO_TITLE);
   //modify the line bellow
    cerrar = (Button) myDialog.findViewById(R.id.cerrar);
    cerrar.setOnClickListener(new View.OnClickListener() {
        @Override
        public void onClick(View view) {
            myDialog.cancel();
        }
    });
    myDialog.show();
}

My progam crashes when using custom dialog

2 Answers2