Combining digits in a file into one

Question

I have an assignment where I am giving a file containing numbers:

5  1 0 1 1 0
4  1 1 9 0 
7  1 1 1 0 1 0 1
10 1 0 1 1 1 0 0 0 1 0

The first numbers (5,4,7 & 10) are there to tell how many digits the binary number should have. Then the numbers after that have to be combined since they have spaces in between.

I know that it would be better if they didn't have spaces but the assignment requires spaces.

My code takes in the fist number which I named numLength to then figure out how many digits the binary value should have. Then it takes in each digit at a time and raises it to the appropriate power so that theoretically when they are all added it should equal the binary number.

For example, 1 0 1 1 0 is turned into 10000 + 0 + 100 + 10 + 0 which equals 10110

This should be happen as there is a binary value on the file.

When I run my program it does not output what it should.

Any suggestions on how I can improve my code to make it do what I want it to do?

#include <iostream> // This library is the basic in/out library
#include <cmath> //This library allows us to use mathematical commands
#include <fstream> //This library will allow me to use files
#include <string> //This will allow me to use strings

using namespace std;
int convertBinaryToDecimal(int);

int combine(int);

int main()
{
    ifstream infile; //I am renaming the ifstream command to infile since it is easier to remember and us
    ofstream outfile; //I also renamed the ofstream to outfile

    infile.open("binary.txt"); //This is opening the binary.txt file which has to be located on the master directory
    int numLength; //This will determine how many digits the binary number will have
    infile >> numLength;
    int digits, binary = 0, DECIMAL;
    int counter = numLength - 1;
    while (!infile.eof())
    {
        infile >> digits;
        for (int i = 0; i < numLength; i++)
        {
            binary = binary + (pow(10, counter) * digits);
            counter = counter - 1;
            infile >> digits;
        }
        cout << binary << endl;
        //DECIMAL = convertBinaryToDecimal(digits);
        //cout << DECIMAL;
        infile >> numLength;
    }

    return 0;
}

When I run my program I get this

Answer 1

#include <iostream> // This library is the basic in/out library
#include <fstream> //This library will allow me to use files
#include <string> //This will allow me to use strings
#include <sstream>

using namespace std;

int main()
{
    ifstream infile; //I am renaming the ifstream command to infile since it is easier to remember and us
    ofstream outfile; //I also renamed the ofstream to outfile

    infile.open("binary.txt"); //This is opening the binary.txt file which has to be located on the master directory
    int numLength; //This will determine how many digits the binary number will have

    string line;
    while (getline(infile, line))
    {
        istringstream iss(line);
        iss >> numLength;

        int digit, binary = 0;

        for (int i = 0; i < numLength; i++)
        {
            iss >> digit;
            if (digit == 1)
                binary |= (numLength - i - 1));
        }

        cout << binary << endl;
    }

    return 0;
}

Live demo

Answer 2

As you have written, I believe you have spaces in the file, that the file must be plain text (UTF-8) and that you only want to print on the screen, so:

#include <iostream> // This library is the basic in/out library
#include <fstream> //This library will allow me to use files
#include <string> //This will allow me to use strings

using namespace std;

int main() {

    int defineLengthOfnumLenght[2]; //limited to 99, but will not pass 64(bits)
    int lengthOfnumLenghtPosition = 0;
    char isWhat; //to test if is number, space or breakline
    bool firstSpaceOfLine = false; //is true if you found first space in the line
    ifstream infile; //I am renaming the ifstream command to infile since it is easier to remember and us
    ofstream outfile; //I also renamed the ofstream to outfile
    int numLength;

    infile.open("binary.txt");

    while (!infile.eof()) {
        infile >> isWhat;
        if (isWhat != ' ' && !firstSpaceOfLine) { //if was number, is not end of line and is not second space - define numLength
            defineLengthOfnumLenght[lengthOfnumLenghtPosition++] = isWhat - '0'; // -'0' will convert ASCII to int, because char is int representing on ASCII table
        }
        else if (isWhat == ' ' && !firstSpaceOfLine) { //when reach first space in line
            firstSpaceOfLine = true;
            if (lengthOfnumLenghtPosition == 1) {
                numLength = defineLengthOfnumLenght[0] - '0';
            }
            else if (lengthOfnumLenghtPosition == 2) {
                numLength = ((defineLengthOfnumLenght[0] - '0') * 10) + defineLengthOfnumLenght[1] - '0';
            }
            cout << numLength << " ";
            lengthOfnumLenghtPosition = 0;
        }
        else { //here will read and "cout" binaries
            firstSpaceOfLine = false;
            for (int i = 0; i < numLength; i++) {
                infile >> isWhat;
                if (isWhat == ' ') {
                    i--;
                }
                else if (isWhat == '\n') {
                    i == numLength;
                }
                else {
                    cout << isWhat - '0';
                }
            }
            cout << "\n";
        }
    }
}

Now you should test, and remember every detail of this code for all the next times because character handling happens a lot in programming!

Also, consider to work with real binaries files (by i or o or nothing fstream file ("nameOfFile.txt or .bin or .anything or nothing , ios::binary);, like ofstream file (file.bin, ios::binary);, and then read as file.read((char *)&yourVariable, sizeof(char or short int or what you want)); - note: here, I always use (char *) before variable, even if its and int or unsigned int (it works, but I dont know why).