Deleting Row with clicking on button PHP PDO (using Pagination) and MySQL

Question

When im clicking the Delete-Button nothing changes and the Record will not be deleted. Where im Doing wrong? I tried some solutions but couldnt solve it still. Would be nice if i could get help.

  //thats the indexcards.php  


  while ($row = $sql->fetch(PDO::FETCH_ASSOC)){ 
    echo'<tr>
    <td>'.$row["ModuleID"] .'</td>

    <td>'.$row["ModuleName"]. '</td> 

    <td>'.$row["IndexcardSuggestionID"]. '</td> 

    <td>'.$row["FrontContent"]. '</td>

    <td>'.$row["BackContent"]. '</td> 

    <td> <a href=../Delete/delete.php?id=". row[\"IndexcardSuggestionID\"]. "\'>DELETE</a></td>

    <td><input type="button" name="accept" value="Accept"></td>

    <td><input type="button" name="conditionally" value="Conditionally"></td> 

    </tr>';



   // And thats the delete.php


    <?php

session_start();

include_once '../../config/connection.php';

$database = new Database();
$db = $database->getConnection();

$id = $_GET['id'];



 $sql = "DELETE FROM IndexcardSuggestions WHERE IndexcardSuggestionsID = $id";


 header('Location: ../Suggestions/indexcards.php');

  ?>

Your code is vulnerable to SQL injection. You should use prepared statements. — Dharman, Nov 27 '19 at 18:55

score 0 · Accepted Answer · answered Nov 27 '19 at 19:02

You are not passing ID properly. Note that you can not use PHP variables within single quotes, everything is considered as a string. Also, as noted in the comment, your code is vulnerable to MySQL injection.

echo'<tr>
        <td>'.$row["ModuleID"] .'</td>

        <td>'.$row["ModuleName"]. '</td>

        <td>'.$row["IndexcardSuggestionID"]. '</td>

        <td>'.$row["FrontContent"]. '</td>

        <td>'.$row["BackContent"]. '</td>

        <td> <a href=../Delete/delete.php?id=".' . $row["IndexcardSuggestionID"]. '"\'>DELETE</a></td>

        <td><input type="button" name="accept" value="Accept"></td>

        <td><input type="button" name="conditionally" value="Conditionally"></td>

        </tr>';

It was helpful with the prepared statements. Got it now – zazaza Nov 27 '19 at 19:27 — zazaza, Nov 27 '19 at 19:27

Deleting Row with clicking on button PHP PDO (using Pagination) and MySQL

1 Answers1