How to create a close button with JavaFX and FXML

Question

I'm new to the community and I don't really know how to ask for help here. I was trying to create a close button for my alert pop Up window, but I'm getting a syntax error. i also would like to perform some actions before the window closes completely.

This is the driver that calls the window to appear:

package sample;

import javafx.fxml.FXMLLoader;
import javafx.scene.Parent;
import javafx.scene.Scene;
import javafx.scene.paint.Color;
import javafx.stage.Modality;
import javafx.stage.Stage;
import javafx.stage.StageStyle;

import java.awt.*;
import java.io.IOException;


public class Controller {

    public static String name;

    public void removeButtonPressed() throws IOException {
        name = "Hello world";
        alertController a = new alertController().starWindow();

    }

}

This is the alert's controller

package sample;

import javafx.application.Platform;
import javafx.fxml.FXML;
import javafx.fxml.FXMLLoader;
import javafx.fxml.Initializable;
import javafx.scene.Node;
import javafx.scene.Parent;
import javafx.scene.control.Button;
import javafx.stage.Modality;
import javafx.stage.Stage;
import javafx.scene.Scene;
import javafx.scene.control.Label;

import java.awt.event.MouseEvent;
import java.io.IOException;
import java.net.URL;
import java.util.ResourceBundle;

public class alertController implements Initializable {

    @FXML
    private Label label = new Label();
    private String s = Controller.name;


    public alertController starWindow() throws IOException {

        Parent root = FXMLLoader.load(getClass().getResource("alert.fxml"));
        Stage window = new Stage();
        window.initModality((Modality.APPLICATION_MODAL));
        window.setTitle("");
        Scene scene = new Scene(root);
        window.setScene(scene);
        window.show();
        return null;
    }

    private void closeButton(MouseEvent event){
        Stage s = (Stage) ((Node)event.getSource().getScene().getWindow()); 
/*I'm getting problems with this part of my code
 the IDE gives me trouble with getScene()*/
        s.close();
    }


    @Override
    public void initialize(URL location, ResourceBundle resources) {
        label.setText(s);
    }
}

this is the alert's FXML file

<?xml version="1.0" encoding="UTF-8"?>

<?import javafx.scene.effect.*?>
<?import javafx.scene.text.*?>
<?import javafx.geometry.*?>
<?import java.lang.*?>
<?import java.util.*?>
<?import javafx.scene.*?>
<?import javafx.scene.control.*?>
<?import javafx.scene.layout.*?>

<VBox maxHeight="141.0" maxWidth="394.0" prefHeight="119.0" prefWidth="307.0" style="-fx-background-radius: 5;" xmlns="http://javafx.com/javafx/8" xmlns:fx="http://javafx.com/fxml/1" fx:controller="sample.alertController">
   <children>
      <AnchorPane>
         <children>
            <Label fx:id="label" layoutX="28.0" layoutY="20.0" maxHeight="35.0" maxWidth="149.0" text="Are You Sure?">
               <font>
                  <Font name="System Bold" size="20.0" />
               </font>
            </Label>
         </children>
      </AnchorPane>
      <Separator maxWidth="307.0">
         <VBox.margin>
            <Insets bottom="10.0" />
         </VBox.margin>
      </Separator>
      <HBox prefHeight="38.0" prefWidth="297.0" spacing="10.0">
         <children>
            <Region HBox.hgrow="ALWAYS" />
            <Button maxHeight="44.0" maxWidth="58.0" mnemonicParsing="false" text="Yes">
               <font>
                  <Font size="15.0" />
               </font>
            </Button>
            <Button maxHeight="44.0" maxWidth="55.0" mnemonicParsing="false" onMouseClicked="#closeButton" text="No">
               <HBox.margin>
                  <Insets right="30.0" />
               </HBox.margin>
               <font>
                  <Font size="15.0" />
               </font>
            </Button>
         </children>
         <VBox.margin>
            <Insets bottom="5.0" left="5.0" right="5.0" top="5.0" />
         </VBox.margin>
      </HBox>
   </children>
</VBox>

I also tried to use setOnAction but the same error happened.

thank you so much!!

Answer 1

Try using onAction="#closeButton" in your FXML code. And I think that this method should be public as well as every node on your stage (s.a. the label that you've annotated with @FXML).

Furthermore you can access the stage by any object on that stage with

Stage stage = (Stage) label.getScene().getWindow();

Hope this helps!

Answer 2

Let's use brackets to clarify how the compiler interprets

Stage s = (Stage) ((Node)event.getSource().getScene().getWindow());

Stage s = (Stage) ((Node) (((event.getSource()).getScene()).getWindow()));

i.e. the cast to Node has lower precedence than the . operator leaving you with an expression of type Object you try to call .getSource() on. Object does not contain a getScene method. Make sure the cast is applied first by adding brackets:

Stage s = (Stage) ((Node) event.getSource()).getScene().getWindow();

---

Also note that even after applying this fix you'll still have issues that will result in exceptions at runtime: You're using some java.awt imports. You need to replace those with the appropriate javafx imports.

I also strongly recommend adhering to the java naming conventions. Starting type names with a lowercase letter can make your code hard to read.

Answer 3

This was the solution to my problem.

Controller:

  @FXML
    private void closeButton(Event event){
        Stage s = (Stage) ((Node) event.getSource()).getScene().getWindow();
        s.close();
    }

FXML code:

<Button maxHeight="44.0" maxWidth="55.0" mnemonicParsing="false" onAction="#closeButton" text="No">

I deleted:

import java.awt.event.MouseEvent;