How to run an sh script in docker file?

Question

When running a sh script in docker file, i got the following error:

./upload.sh: 5: ./upload.sh: sudo: not found ./upload.sh: 21:
./upload.sh: Bad substitution

sudo chmod 755 upload.sh # line 5
version=$(git rev-parse --short HEAD)
echo "version $version"
echo "Uploading file"

for path in $(find public/files -name "*.txt"); do
  echo "path $path"
  WORDTOREMOVE="public/" 
  echo "WORDTOREMOVE $WORDTOREMOVE"
  # cause of the error
  newpath=${path//$WORDTOREMOVE/} # Line 21
  echo "new path $path"
  url=http://localhost:3000/${newpath}
  ...
  echo "Uploading file"
  ...
done

DockerFile

FROM node:10-slim

EXPOSE 3000 4001


WORKDIR /prod/code
...
COPY . .

RUN ./upload.sh
RUN npm run build
CMD ./DockerRun.sh

Any idea?

This should help `https://stackoverflow.com/questions/25845538/how-to-use-sudo-inside-a-docker-container` — thechaoticpanda, Dec 26 '19 at 00:05
I don't understand what do you mean exactly, but i try to build docker image locally docker build -t myApp . — user2222, Dec 26 '19 at 00:05
if sudo is not found, you probably need to install it in the container — thechaoticpanda, Dec 26 '19 at 00:07
You are using a `bash` extension (`${path//...}`) but trying to run the script using `/bin/sh`. — chepner, Dec 26 '19 at 00:27
You also probably don't need `sudo` at all – things in a Dockerfile usually run as root unless you explicitly pick a different `USER`. — David Maze, Dec 26 '19 at 01:00

user2222 · Accepted Answer · 2019-12-29T18:10:29.543

3

If anyone faces the same issue, here how I fixed it

chmod +x upload.sh
git update-index --chmod=+x upload.sh (mandatory if you pushed the file to remote branch before changing its permission)

edited Dec 29 '19 at 18:10

answered Dec 28 '19 at 16:14

user2222

444
2
8
18

score 1 · Answer 2 · answered Dec 26 '19 at 07:28

The docker image you are using (node:10-slim) has no sudo installed on it because this docker image runs processes as user root:

docker run -it node:10-slim bash root@68dcffceb88c:/# id uid=0(root) gid=0(root) groups=0(root) root@68dcffceb88c:/# which sudo root@68dcffceb88c:/#

When your Dockerfile runs RUN ./upload.sh it will run: sudo chmod 755 upload.sh

Using sudo inside the docker fails because sudo is not installed, there is no need to use sudo inside the docker because all of the commands inside the docker run as user root.

Simply remove the sudo from line number 5.

If you wish to update the running PATH variable run:

PATH=$PATH:/directorytoadd/bin

This will append the directory "/directorytoadd/bin" to the current path.

actually i want to remove WORDTOREMOVE from path (remove substring from string) — user2222, Dec 26 '19 at 08:50

How to run an sh script in docker file?

2 Answers2