Why does my Test not pass for passing a null List?

Question

I am working in C# building a form application. I have a method that takes in a type of List and returns a hashtable. I am trying to throw an argument exception if the the list is null. My program works the way it should and returns the results I need.

This is the error

Message:   Expected: <System.Exception>
  But was:  <System.NullReferenceException: Object reference not set to an instance of an object.
   at WordOccurenceCalculator.WordCalculator.CalculateOccurrences(List`1 List)

public void CalculateOccurrencesShouldThrowException() {

            List<string> list = null;
            WordCalculator calc = new WordCalculator();

            Assert.Throws<Exception>(delegate { calc.CalculateOccurrences(list); });
}


 public Hashtable CalculateOccurrences(List<string> List)
        {
            if ( List.Count == 0)
            {
                throw new System.ArgumentException("Invalid Input");
            }

            if (List == null)
            {
                throw new System.ArgumentException("Invalid Input");
            }


            Hashtable table = new Hashtable();
            int counter = 1;
            int j = 1;
            for (int i = 0; i < List.Count; i++)
            {
                for(j = i + 1 ; j <= List.Count; j++)
                {
                   if(j < List.Count){
                if (List[i] == List[j])
                {
                    counter++;
                }
            }
                }
                if (!table.Contains(List[i]))
                {
                    table.Add(List[i], counter);

                }
                counter = 1;

            }

            return table;
        }

@AlexeiLevenkov I am not sure I understand your question. Can you please clarify it for me. Thank you. — ZST, Jan 31 '20 at 05:22
check `Assert.Throws` [documentation](https://github.com/nunit/docs/wiki/Assert.Throws#exact-versus-derived-types), the exact type should be thrown, not a derived type — jalsh, Jan 31 '20 at 06:00

Badhon Jain · Answer 1 · 2020-02-05T03:09:43.250

-1

you are checking null after trying to access count property of null list. You would get exception from there too. Try the bellow.

      if (List == null)
        {
            throw new System.ArgumentException("Invalid Input");
        }

       if ( List.Count == 0)
        {
            throw new System.ArgumentException("Invalid Input");
        }

edited Feb 05 '20 at 03:09

answered Jan 31 '20 at 05:14

Badhon Jain

938
6
20
38

Why does my Test not pass for passing a null List?

1 Answers1