Gin keeps returning 204 when uploading file

Question

I am getting a 204 with OPTIONS method, but the end-point doesn't seem to be hit

Just building a simple file-upload endpoint like this:

package main

import  (
    "cloud.google.com/go/storage"
    "github.com/gin-gonic/gin"
    "github.com/gin-contrib/cors"
    "google.golang.org/api/option"
    "io"
    "log"
)

 const uploadBucket = "some-cool-bucket-name"
 const uploadApiKey = "some-advanced-key"

func main() {
    router := gin.Default()

    rg := router.Group("api/v1/photo")
    {
        rg.PATCH("/", uploadFile)
    }

    router.Use(cors.Default())

    router.Run()
}

func uploadFile(c *gin.Context) {
    mr, e := c.Request.MultipartReader()
    if e != nil {
        panic("Error reading request")
    }

    client, e := storage.NewClient(c, option.WithAPIKey(uploadApiKey))
    bucket := client.Bucket(uploadBucket)

    for {
        p, e := mr.NextPart()

        if e == io.EOF {
            break
        } else if e != nil {
            panic("Error processing file")
        }

        w := bucket.Object(p.FileName()).NewWriter(c)

        if _, e := io.Copy(w, p); e != nil {
            panic("Error during chunk upload")
        } else if e := w.Close(); e != nil {
            panic("Could not finalize chunk writing")
        }

    }
}

Any ideas why?

You are only watching for `PATCH` methods in your upload route. Have a look at [file uploads section from the gin README](https://github.com/gin-gonic/gin#upload-files) — segFault, Feb 22 '20 at 12:48
I still don't see what is the problem. I am using PATCH in my front-end so it should match with this endpoint in gin. — FailedUnitTest, Feb 22 '20 at 12:53
That's normal behaviour 204 is a default response for gin OPTIONS request. Are you sure you have correct `CORS` setup? — Roman Kiselenko, Feb 22 '20 at 13:10
Does this answer your question? [Go gin framework CORS](https://stackoverflow.com/questions/29418478/go-gin-framework-cors) — segFault, Feb 22 '20 at 13:14

score 5 · Answer 1 · answered Feb 22 '20 at 17:15

Use below CORS:

func CORS() gin.HandlerFunc {
    // TO allow CORS
    return func(c *gin.Context) {
        c.Writer.Header().Set("Access-Control-Allow-Origin", "*")
        c.Writer.Header().Set("Access-Control-Allow-Headers", "Content-Type, Content-Length, Accept-Encoding, X-CSRF-Token, Authorization, accept, origin, Cache-Control, X-Requested-With")
        c.Writer.Header().Set("Access-Control-Allow-Methods", "POST, OPTIONS, GET, PUT, DELETE")
        if c.Request.Method == "OPTIONS" {
            c.AbortWithStatus(204)
            return
        }
        c.Next()
    }
}

Next, you have to add cors to your routes:

    router := gin.Default()
    router.Use(CORS())

Plus it will be better to use POST method instead of PATCH. I am quite sure it will solve your problem.

segFault · Answer 2 · 2020-02-22T13:13:53.590

0

You may be able to achieve this by using a POST method instead of PATCH.

For example:

func main() {
    router := gin.Default()

    rg := router.Group("api/v1/photo")
    {
        rg.POST("/", uploadFile)
    }

    router.Use(cors.Default())

    router.Run()
}

Potential CORS Issue

You may need to setup proper Cross-Origin Resource Sharing in your Go service.

Some additional references

SO answer on differences between common HTTP methods - What is the difference between PUT, POST and PATCH?.

PATCH: Submits a partial modification to a resource. If you only need to update one field for the resource, you may want to use the PATCH method.

How does HTTP file upload work?

edited Feb 22 '20 at 13:13

answered Feb 22 '20 at 12:55

segFault

3,887
1
19
31

I changed everything to POST. Exactly same result unfortunately. – FailedUnitTest Feb 22 '20 at 13:00
So the `OPTIONS` request is being made automatically client-side. You need to handle that as well on your server. It might be helpful to see the POST request you are sending to the server from the form. Is the go service running from the same domain/host as the form/client? – segFault Feb 22 '20 at 13:07
1

gin handle `OPTIONS` request automatically. – Roman Kiselenko Feb 22 '20 at 13:12

Gin keeps returning 204 when uploading file

2 Answers2

Potential CORS Issue

Some additional references