GridView elements changes their place dynamically when scroll screen

Question

i have a gridview layout, and all items are insert very fine,

now if I check on big screen then all work done is fine, because no scrolling is required

but if I check on small screen then items are changed their position dynamically,

bereif example is given below:-

like I have 28 items and arranged in a grid view 7*4, now if upto 20 items are shown in first screen, now remaining 8 is shown while i scroll screen down, but now some elements of first or second row is aslo put in last row.

code is here

public class ImageAdapter extends BaseAdapter
    {
        Context mContext;
        //public static final int ACTIVITY_CREATE = 10;
        public ImageAdapter(Context c)
        {
            mContext = c;
        }
        @Override
        public int getCount() 
        {
            // TODO Auto-generated method stub
            return providers.length;
        }

        @Override
        public View getView(int position, View convertView, ViewGroup parent) 
        {
            // TODO Auto-generated method stub
            View v;
            if(convertView==null)
            {
                LayoutInflater li = getLayoutInflater();
                v = li.inflate(R.layout.icontext, null);
                TextView tv = (TextView)v.findViewById(R.id.icon_text);
                tv.setText(providers[position]);
                ImageView iv = (ImageView)v.findViewById(R.id.icon_image);
            iv.setImageResource(R.drawable.icon);
            }
            else
            {
                v = convertView;
            }
            return v;
        }

Can publish any code? For example your adapter code? – Huds0nHawk May 19 '11 at 08:44 — Huds0nHawk, May 19 '11 at 08:44
I paste the ImageAdapter code, plz see it – DEVANG SHARMA May 19 '11 at 11:08 — DEVANG SHARMA, May 19 '11 at 11:08
hey i paste the code, now can you suggest me – DEVANG SHARMA Jun 11 '11 at 17:04 — DEVANG SHARMA, Jun 11 '11 at 17:04

score 56 · Accepted Answer · answered Jun 12 '11 at 09:31

56

You should change your getView method like this.

    public View getView(int position, View convertView, ViewGroup parent){
        // TODO Auto-generated method stub
        View v;
        if(convertView==null)
        {
            LayoutInflater li = getLayoutInflater();
            v = li.inflate(R.layout.icontext, null);
        }else{
            v = convertView;
        }
        TextView tv = (TextView)v.findViewById(R.id.icon_text);
        tv.setText(providers[position]);
        ImageView iv = (ImageView)v.findViewById(R.id.icon_image);
        iv.setImageResource(R.drawable.icon);

        return v;
    }

Your problem is that when you use convertView it stores old data form the first records. Convert view is used to avoid layout inflation from resource which costs you time and memory. You should use the old inflated view, but set new data.

answered Jun 12 '11 at 09:31

Huds0nHawk

1,486
16
26

Hi, I am having same problem. But I have checkBox in place of TextView. When ever there is change in view, the checkboxes which are checked changes – ChanChow Nov 24 '12 at 21:06
3

Its work for me, but while Scrolling its not working smoothly..?? – Pratik Butani Oct 10 '13 at 12:02
1

how to achieve smooth scrolling in this? – Mayur R. Amipara Mar 18 '15 at 06:08
I've update my code but it's not working, any help please I need it badly: http://stackoverflow.com/questions/32401630/gridview-images-are-changing-postion-when-scrolling – Monzer Yaghi Sep 04 '15 at 16:04
I also confirm that scrolling get's really laggy after this modification. Any ideas how to solve this? – stavros.3p Dec 30 '20 at 00:21

score 2 · Answer 2 · answered Feb 11 '14 at 17:07

2

I have just deleted the

if(convertView==null)

it works

answered Feb 11 '14 at 17:07

Boris Karloff

1,190
12
20

1

Yea, that fixes the issue. But the performance becomes totally terrible. – careful7j Sep 23 '16 at 00:10
This fixed my issue. Thanks Boris – Firnaz May 25 '17 at 09:27

GridView elements changes their place dynamically when scroll screen

2 Answers2

Linked