Java If Statement having multiple conditions with && operator not working

Question

private void validate(String userName, String userPassword){
        if((userName == "Admin") && (userPassword == "1234")){
            Intent intent = new Intent(MainActivity.this, SecondActivity.class);
            startActivity(intent);
        } else{
            counter --;
            Info.setText(userName + " Number of Attempts Left: "+String.valueOf(counter) + " - " + userPassword);
            if(counter == 0){
                Login.setEnabled(false);
            }
        }
    }

Whenever i give input as "Admin" and "1234" condition goes to else part. please help me i am beginner in this field.

Try if (userName.equals("Admin") && userPassword.equals( "1234")){} — Prasanth S, Mar 10 '20 at 07:05

score 1 · Accepted Answer · answered Mar 10 '20 at 07:05

1

string equals() method compares the two given strings based on the data/content of the string.

Try with

  if(userName.equals("Admin") && userPassword.equals("1234")){
            Intent intent = new Intent(MainActivity.this, SecondActivity.class);
            startActivity(intent);
        } else{
            counter --;
            Info.setText(userName + " Number of Attempts Left: "+String.valueOf(counter) + " - " + userPassword);
            if(counter == 0){
                Login.setEnabled(false);
            }
        }

answered Mar 10 '20 at 07:05

IntelliJ Amiya

74,896
15
165
198

1

Thanks for your answer. But can you please tell me what's the problem with "==" – Mohit Mar 10 '20 at 07:21
2

@Mohit == compares the references to the objects, not their value – Stultuske Mar 10 '20 at 07:22
2

@IntelliJAmiya == goes for all primitive types, enums, ... – Stultuske Mar 10 '20 at 07:23

score 0 · Answer 2 · answered Mar 10 '20 at 07:06

0

You should compare strings using equals method:

"Admin".equals(UserName)

BTW, the code above is a bit safer than

UserName.equals("Admin")

because it does not throw NullPointerException when UserName is null.

answered Mar 10 '20 at 07:06

Alex Sveshnikov

4,214
1
10
26

score 0 · Answer 3 · edited Mar 10 '20 at 07:21

0

== tests for reference equality (whether they are the same object).

.equals() tests for value equality (whether they are logically "equal").

Therefore use .equals(), or equalsIgnoreCase() instead of == for comparing String objects.

edited Mar 10 '20 at 07:21

Stultuske

9,296
1
25
37

answered Mar 10 '20 at 07:06

Deepak Tatyaji Ahire

4,883
2
13
35

Java If Statement having multiple conditions with && operator not working

3 Answers3