Show spinning wheel dialog while loading data on Android

Question

I want to show a spinning wheel dialog while my app loads some data:

Spinning wheel dialog

The spinning wheel dialog should show on a button click. I’m using the code below but it does now show the spinning wheel. What could be the problem?

public void CheckAccount(String username, String password) {
    try {

        final ProgressDialog progDailog = ProgressDialog.show(this,
            "Progress_bar or give anything you want",
            "Give message like ....please wait....", true);
        new Thread() {
            public void run() {
                try {
                    // sleep the thread, whatever time you want. 
                    sleep(1000);
                } catch (Exception e) {
                }
                progDailog.dismiss();
            }
        }.start();

        //getting data code here
        //getting data code here
        //getting data code here
        //getting data code here
        //getting data code here

    } catch (Exception e) {
        Log.e(LOG_TAG, e.getMessage());
        PopIt("CheckAccountError", e.getMessage(), "Denied");
    }
}

score 50 · Accepted Answer · edited May 23 '17 at 12:32

So, seeing that this answer is getting more and more upvotes, I have decided that I should take it upon myself to improve the quality of the answer. As I look at the original, I see no real 'answer' to the question of "what is the problem in my code?". I am leaving the original answer intact below to preserve the linking, which is what I am assuming has caused the answers popularity.

Updated Answer

It is likely that you are violating the 'single thread model'. The Android UI Toolkit is not threadsafe, and should only be manipulated from the 'main' UI thread. Android has a handful of helpful methods you can use to ensure that your UI manipulations are done on the UI thread. Most of the details of these method calls can be found in the Android Painless Threading blog post (linked in the word 'one' below, and here for quick reference).

Looking at your code, the specific violation I see is that a ProgressDialog is being created in what is likely the UI thread, which is then dismissed in the newly created background thread.

You would be better off encapsulating your background method in a Runnable and using View#post(Runnable) to do the work in the background.

Remember, there are many ways to do background, so take a look at what is available, and use what feels right for your situation.

Original Answer

Take a look at one of the many tutorials of how to do asynchronous work in Android.

Also, here are some other StackOverflow questions that are similar

Progress dialog problem in Android

Progress Dialog on open activity

Progress Dialog while starting new activity

Android: Progress Dialog spinner not spinning

Updating progress dialog

android: showing a progress dialog

love the use of referencing, +1 :) – xorinzor Oct 31 '12 at 21:01 — xorinzor, Oct 31 '12 at 21:01

score 49 · Answer 2 · edited Dec 06 '18 at 04:36

49

To create.

ProgressDialog dialog = new ProgressDialog(this); // this = YourActivity
dialog.setProgressStyle(ProgressDialog.STYLE_SPINNER);
dialog.setTitle("Loading");
dialog.setMessage("Loading. Please wait...");
dialog.setIndeterminate(true);
dialog.setCanceledOnTouchOutside(false);

To show.

dialog.show();

To dismiss.

dialog.dismiss();

edited Dec 06 '18 at 04:36

Joshua Pinter

45,245
23
243
245

answered Feb 20 '15 at 11:27

Abhi

1,043
12
7

1

Worked like charm. However how to stop it once data has been loaded? – MMG May 27 '17 at 03:20
2

To hide the dialog call `dialog.dismiss();` – Gabriel Hobold Dec 07 '17 at 18:42
1

ProgressDialog is deprecated and will likely be removed in future iterations of Android – Karan Harsh Wardhan Dec 14 '18 at 07:13

score 1 · Answer 3 · answered Dec 15 '15 at 16:37

I had the problem of switching between two activities, Activity A and Activity B. Activity B had long running tasks that was updating the UI, so it was not a candidate for AsyncTask. I solved it by launching a progress dialog on Activity A and launching Activity B before we finished the first activity. The Code Looks like:

            // wrap thread around original code for progress button
            final ProgressDialog ringProgressDialog = ProgressDialog.show(getActivity(), "Working", "Please Wait",
                    true, false);
            ringProgressDialog.setIndeterminate(true);
            new Thread(new Runnable() {
                public void run() {
                    try {

                        Intent startNewActivityOpen = new Intent(getActivity(), ActivityB.class);
                        startNewActivityOpen.setFlags(Intent.FLAG_ACTIVITY_PREVIOUS_IS_TOP);
                        startActivity(startNewActivityOpen);
                        GlobalVars.navigateFromScreen = true;

                        Thread.sleep(3000);


                        if (ringProgressDialog != null && ringProgressDialog.isShowing()) {
                            ringProgressDialog.dismiss();
                        }

                        getActivity().finish();


                    } catch (Exception e) {

                    }

                }

            }).start();

Show spinning wheel dialog while loading data on Android

3 Answers3

To create.

To show.

To dismiss.

Linked