Its a function that checks whether a string is a Pangram or not
so if str1 == 'the quick brown fox jumps over the lazy dog' the function will return True since the string contains every letter in the alphabet.
import string
def ispangram(str1, alphabet=string.ascii_lowercase):
for char in set(alphabet):
if char in str1:
return True
else:
return False
As soon as a first letter is found in the str1, the function returns True.
What you need to do instead is:
def ispangram(str1, alphabet=string.ascii_lowercase):
for char in set(alphabet):
if char not in str1:
return False
return True
This way the function returns False only if char is not in str1 and only after all the characters are found to be present in the str1 it returns True.
You might want to use str1.lower(), because you are checking for lowercase letters only.
Without knowing exactly what your function is supposed to do, I suspect the issue is that you return either True or False in the first iteration of the loop, so only the first letter is ever analyzed. Try this:
import string
def ispangram(str1, alphabet=string.ascii_lowercase):
for char in set(alphabet):
if char not in str1:
return False
return True
Here is a different approach from yours:
import string
def ispangram(str1, alphabet=string.ascii_lowercase):
return len(set(l.lower() for l in str1 if l.lower() in alphabet)) == len(alphabet)
print(ispangram("I am very tired, but I will keep programming to pass the quiz!"))
Output:
False
You don't need to set(alphapet), you can iterate alphabet directly.
If you in the condition that function will return False then the function will exit without executing the following lines so after finishing the for-loop without returning false then we have pangram case so the function will directly return True.
import string
def ispangram(str1, alphabet=string.ascii_lowercase):
for char in alphabet:
if char not in str1:
return False
return True
str1 = 'the quick brown fox jumps over the lazy dog'
print(ispangram('Hello')) #False
print(ispangram(str1)) #True
However, we can shorten our function using all() to be
def ispangram(str1, alphabet=string.ascii_lowercase):
return all([char in str1 for char in alphabet])
As noted elsewhere, you have your logic inverted and incorrectly indented. But your design is nice in that it naturally ignores characters that aren't letters. I would add some defense against mixed case and simplify it slightly:
from string import ascii_lowercase as alphabet
def ispangram(string):
string = string.lower()
for character in alphabet:
if character not in string:
return False
return True
print(ispangram('Watch "Jeopardy!", Alex Trebek\'s fun TV quiz game.'))
Your function returns True if any alphabet characters are found in your string. Is that what you wanted? It runs through the cars in set(alphabet), and if any of them are in your string if char in str1, it returns True. That doesn't seem very useful for your goal. You probably want more complicated logic, that checks the order of characters, whether the string is identical when reversed if you are looking at palindromes, etc. Hope this helps guide you!
Consider the input "abc". When your function iterates through the letters in the alphabet, it starts with "a", sees that it's in the input string, and then returns True. You need to check to make sure that all the letters from the alphabet are in the input string
Your function returns directly after checking the first character of alphabet, regardless of whether the character in in str1. In fact, you function simply checks if some character of the alphabet is in you string.
What you intended to do was:
import string
def ispangram(str1, alphabet=string.ascii_lowercase):
for char in set(alphabet):
if char not in str1:
return False
else:
return True
However, a much simpler solution would simply be:
def ispangram(str1, alphabet=string.ascii_lowercase)
return set(str1) >= set(alphabet)
