Write a function that accepts a string and returns a new string with just the vowels

Question

I need help figuring out what is wrong with my code. I think the logic makes sense, but I'm not sure why it's not working.

function vowelsOnly(str) {
  var string2 = "";
  for(var i = 0; i < str.length; i++){
  if(str[i] === "a" || "e" || "i" || "o" || "u"){
    string2 += (str[i]);
  }
  }
  return string2;
}

Your code says: If the value at index i is equal to "a" or if "e" is truthy. That is not how you check if something is equal to many things. — epascarello, Jun 16 '20 at 21:38
https://stackoverflow.com/questions/4728144/check-variable-equality-against-a-list-of-values — epascarello, Jun 16 '20 at 21:40

score 0 · Answer 1 · answered Jun 16 '20 at 21:34

You need to fix the condition like so:

function vowelsOnly(str) {
  var string2 = "";
  for(var i = 0; i < str.length; i++){
  if(str[i] === "a" || str[i] === "e" || str[i] === "i" || str[i] === "o" || str[i] === "u"){
    string2 += (str[i]);
  }
  }
  return string2;
}

shim-kun · Accepted Answer · 2020-06-16T21:42:01.550

0

You need to repeat the complete condition everytime like this:

function vowelsOnly(str) {
  var string2 = "";
  for(var i = 0; i < str.length; i++) { 
      if(str[i] === "a" || str[i] === "e" || 
      str[i] === "i" || str[i] === "o" ||
      str[i] === "u") { 
      string2 += (str[i]); 
      }
   }
 return string2; 
 }

edited Jun 16 '20 at 21:42

answered Jun 16 '20 at 21:36

shim-kun

123
2
10

score 0 · Answer 3 · answered Jun 16 '20 at 21:45

another way is by regExp and replace method.

function vowelsOnly(str) {
 return str.replace(/[^aeiouAEIOU]/gi, '')
}
console.log(vowelsOnly("hello"));


function disemvowel(str) {
return str.replace(/[aeiouAEIOU]/gi, '');
}
console.log(disemvowel("hello"));

Write a function that accepts a string and returns a new string with just the vowels

3 Answers3