Adding HTML codes inside PHP

Question

I'm trying to add a view button to my table but I'm getting a syntax error, unexpected href. Seems like I'm wrong with the formatting. Still trying to learn PHP but is it possible to add href to the table?

Here's my code:

while($row = mysqli_fetch_array($result))
{
    $output .= '
        <tr>
            <td>'.$row["name"].'</td>
            <td>'.$row["temperature"].'</td>
            <td>'.$row["phoneno"].'</td>
            <td> '<a href='read.php?id='. $row['id'] .'' title='View Record' data-toggle='tooltip'><i class='fa fa-eye' style='font-size:30px; color: black;''></i></a>';' </td>
        </tr>
    ';
}
echo $output;

And here's the image for the color coding that seems wrong.

It is because you're using single quotes to delimit your strings while using single quotes in the strings to denote values. — Jay Blanchard, Jul 30 '20 at 14:38
Does this answer your question? [PHP parse/syntax errors; and how to solve them](https://stackoverflow.com/questions/18050071/php-parse-syntax-errors-and-how-to-solve-them) — Nico Haase, Jul 30 '20 at 14:43

Jay Blanchard · Accepted Answer · 2020-07-30T14:47:22.483

3

It is because you're using single quotes to delimit your strings while using single quotes in the strings to denote values.

This -

<td> '<a href='read.php?id='. $row['id'] .'' title='View Record' data-toggle='tooltip'><i class='fa fa-eye' style='font-size:30px; color: black;''></i></a>';' </td>

Should be this -

<td><a href="read.php?id='. $row['id'] .'" title="View Record" data-toggle="tooltip"><i class="fa fa-eye" style="font-size:30px; color: black;"></i></a></td>';

edited Jul 30 '20 at 14:47

answered Jul 30 '20 at 14:42

Jay Blanchard

34,243
16
77
119

1

I was able to understand after reading this article **PHP parse/syntax errors; and how to solve them** but the answer is a good guide that would help. Thanks so much for the help!! – Renzo Jul 30 '20 at 14:51

Álvaro González · Answer 2 · 2020-07-30T14:50:20.337

3

Just mismatched quotes.

There're many ways to mix PHP and HTML and you've chosen a hard syntax. Please compare with e.g.:

<?php foreach($foo as $row) { ?>
    <tr>
        <td><?= $row["name"] ?></td>
        <td><?= $row["temperature"] ?></td>
        <td><?= $row["phoneno"] ?></td>
        <td>
            <a href='read.php?id=<?= $row['id'] ?>' title='View Record' data-toggle='tooltip'><i class='fa fa-eye' style='font-size:30px; color: black;'></i></a>
        </td>
    </tr>
<?php }

BTW, your are injecting raw text into HTML, beware that it can break your markup any time.

edited Jul 30 '20 at 14:50

answered Jul 30 '20 at 14:47

Álvaro González

142,137
41
261
360

I flip flop between the two myself. When I can, I use the above method, however if I have to put all the html into a variable for method return, I do the concat style in the OP (because I detest using ob_funcs to capture pieces). All good examples here. – IncredibleHat Jul 30 '20 at 14:52

score 2 · Answer 3 · answered Jul 30 '20 at 14:41

Your quotes are all over the place. You open a string variable with single quotes so every time you use single quotes unescaped in the string you just created will be interrupted.

It should be like this: <a href="read.php?id='.$row['id'].'" ... >

Adding HTML codes inside PHP

3 Answers3