How to Calculate the size of the given code using Halsted’s Metric?

Question

When I execute below code it gives me this message

Error - At least one public class is required in main file

Here is the link of the program.

    #include <iostream.h>
    #include <conio.h>
    
    void main() {
        int a, b, c;
        int sum = 0;
        int sub;
        float prod = 1;
        float div;
        if (12 < a < 20)
            sum = a + b + c;
        else if (b > 30)
            sub = b - c;
        else if (10 < c < 18)
            prod = a * b;
        else
            div = c / a;
        cout <<” The values of sum, sub, prod and div are :”<< sum << sub << prod << div;
        getch();
    }

`void main()` should be `int main()`. `(12 < a < 20)` should be `(12 < a && a < 20)`. It appears you could use a [good C++ book](https://stackoverflow.com/a/388282/4641116). — Eljay, Aug 24 '20 at 13:35
The code appears to be C++ (albeit not quite well-formed). Why the `c` and `java` tags? — Eljay, Aug 24 '20 at 13:43
There is a "share" button there. Add a link to that to your question. — cigien, Aug 24 '20 at 13:59
I tried your link, and I'm getting completely different error messages, regarding `cout` not being available, etc. — cigien, Aug 24 '20 at 14:53

score 0 · Answer 1 · answered Aug 24 '20 at 16:06

I'm not sure what does your code do, but there are lots of logical & syntactical errors:

Seemingly you're using a deprecated compiler because iostream.h is no longer used.
The values of the variables a, b & c are kept uninitialized, thus, it contains some garbage values.
The syntax:
```
if (10 < c < 18)
```
is incorrect. The correct idea should be:
```
if (10 < c && c > 18)
```
The token ” is unknown and cannot be used.
The declaration of the main function:
```
void main() {}
```
is incorrect as well. The right way to do it is:
```
int main(void) {}
```

Assuming the value of a is initialized to 1, because if the values of b & c are kept zero (probably you want it), the else condition will take place, i.e. division of c with a, which yields illegal instruction error.

After solving these issues, the correct code would look like:

#include <iostream>

int main(void)
{
  // All the variables must be initialized if they are going to be used
  int a = 1, b = 0, c = 0;

  int sum = 0;
  int sub = 0;
  float prod = 1;
  float div = 0;

  if (12 < a && a > 20)
    sum = a + b + c;
  else if (b > 30)
    sub = b - c;
  else if (10 < c && c > 18)
    prod = a * b;
  else
    div = c / a;

  std::cout << "The values of sum, sub, prod and div are :"
            << sum << sub << prod << div << std::endl;

  return 0;
}

How to Calculate the size of the given code using Halsted’s Metric?

1 Answers1