How can I generate the squares of the digits of an integer

Question

I am trying to write a command line program that accepts inputs. If the input is an integer , it squares every digit of the number and concatenate them but if the input is not an integer then it asks the user to input a digit. But the output is wrong. Please Check the code.

package com.company;
import java.util.*;

public class ExerciseB {
  public static void main (String[] args) {
    while (true) {
        System.out.println("Enter a digit or 'quit' to quit: ");
        Scanner userInput = new Scanner(System.in);
        if (userInput.hasNextInt()) {
            int intInput = userInput.nextInt();
            int i;
            int intCharSquare;
            ArrayList<Integer> valueCharSquare = new ArrayList<>();

            //Generating the square of each character of the inputted integer and adding it to the valueCharSquare ArrayList
            String stringOfIntInput= String.valueOf(intInput);
            for (i = 0; i <= stringOfIntInput.length() - 1; i++) {
                intCharSquare = (int) Math.pow((int) stringOfIntInput.charAt(i),2);
                valueCharSquare.add(intCharSquare);
            }
                // Storing the first value of the valueCharSquare ArrayList into a variable
                int result = valueCharSquare.get(0);

                //Converting the value of result into a string
                String.valueOf(result);

                /* Obtaining the other values of the valueCharSquare ArrayList
                 * and storing them into otherResult variable
                 * then converting otherResult into a string
                 * then concatenating the values of result and otherResults
                 */
            for (i = 1; i <= valueCharSquare.size() - 1; i++) {
                int otherResults = valueCharSquare.get(i);
                String.valueOf(otherResults);
                result = result + otherResults;
            }
                //printing out new value of result
                System.out.println(result);

                // This happens if the user input is a string
        } else if (userInput.hasNext()) {
            String stringInput = userInput.nextLine();
            if (stringInput.equals("quit")) {
                break;
            } else {
                continue;
            }
        }
    }
  }

}

Please read "How to create a [mcve]". Then use the [edit] link to improve your question (do not add more information via comments). — GhostCat, Aug 31 '20 at 11:43
Could you please explain what exactly *... the output is wrong* means? Can you add input as well as desired and actual output to your question? — deHaar, Aug 31 '20 at 11:43
Showing "Actual" & "Expected" output will give more clarity on the question — AbhiN, Aug 31 '20 at 11:45
And just maybe: https://stackoverflow.com/questions/13102045/scanner-is-skipping-nextline-after-using-next-or-nextfoo — GhostCat, Aug 31 '20 at 11:45

score 1 · Answer 1 · answered Aug 31 '20 at 12:06

You should write a separate method for squaring the digits of an integer, e.g. something like this:

static String squareDigits(int number) {
    String numberString = Integer.toString(number);
    StringBuilder buf = new StringBuilder();
    if (number < 0)
        buf.append('-');
    for (int i = (number < 0 ? 1 : 0); i < numberString.length(); i++) {
        int digit = Character.digit(numberString.charAt(i), 10);
        buf.append(digit * digit);
    }
    return buf.toString();
}

Then you can test it independently of your user input/output logic:

System.out.println(squareDigits(13579));       // prints: 19254981
System.out.println(squareDigits(-2468));       // prints: -4163664
System.out.println(squareDigits(0));           // prints: 0
System.out.println(squareDigits(1999999999));  // prints: 1818181818181818181

How can I generate the squares of the digits of an integer

1 Answers1