What I'm doing wrong with this structure?

Question

So, I'm making a structure that works with videos that is supposed to import them from a txt file and I get an error on line 42(uninitialized local variable filme use) and I don't know how to fix it. I can't change Main function.

Any help please ?

#include <iostream>
#include <fstream>
#include<string>
#include<vector>

using namespace std;

struct Filme {
public:
    //string name;
    int anu;
    string denumire;
    //int ani;
    //vector<string>den;

    
};
void Import(int n, Filme* film,string den) {
    
    ifstream ifs(den);
    string denumire;
    int anu;
    while (!ifs.eof()) {
        ifs >> denumire >> anu;
        film->denumire = denumire;
        film->anu = anu;
    }
}
void Afisare(Filme *filme)
{
    cout << filme->denumire<< endl;
    cout << filme->anu << endl;
}
int main()
{
    Filme* filme;
    int n;
    cout << "Cate filme doriti sa importati din fisier: ";
    cin >> n;
    Import(n, filme, "filme.txt");
    //Sort(filme);
    Afisare(filme);

    return 0;
}

you create a new filme variable `Filme* filme` but never assign any value to it. — IndieGameDev, Sep 28 '20 at 06:04
[Why is iostream::eof inside a loop condition (i.e. `while (!stream.eof())`) considered wrong?](https://stackoverflow.com/questions/5605125/why-is-iostreameof-inside-a-loop-condition-i-e-while-stream-eof-cons) — molbdnilo, Sep 28 '20 at 07:13

score 1 · Answer 1 · answered Sep 28 '20 at 06:04

1

you should not do this

film->denumire = denumire;

in

void Import(int n, Filme* film,string den) {

because film is a non initialized pointer you created in main...

Filme* filme;
....
Import(n, filme, "filme.txt");

you have to init it properly

Filme* filme = new Filme...

answered Sep 28 '20 at 06:04

ΦXocę 웃 Пepeúpa ツ

47,427
17
69
97

Can I fix it without changing `Main` ? I'm supposed to make it work without changing it – Bulgaruandrei_Ti_007 Sep 28 '20 at 06:08

score 0 · Answer 2 · answered Sep 28 '20 at 06:10

0

You just define a pointer. Where is its memory allocation?! ;)

Filme* filme = new Filme();

pay attention to delete the pointer at the end.

delete filme;
filme = nullptr; //for c++11

answered Sep 28 '20 at 06:10

alireza

58
5

I can't change `Main` function, any way to fix it without changing it ? – Bulgaruandrei_Ti_007 Sep 28 '20 at 06:12
You can do what @YvonneY says in his post If you can modify the Import function. – alireza Sep 28 '20 at 07:04

score 0 · Answer 3 · edited Sep 28 '20 at 09:45

0

You may refers to the topic C++ how to pass an uninitialized pointer to a function

void Import(int n, Filme* &film, string den) {

    ifstream ifs(den);
    string denumire;
    int anu;
    while (!ifs.eof()) {
        ifs >> denumire >> anu;
        film = new Filme();
        film->denumire = denumire;
        film->anu = anu;
    }
}

edited Sep 28 '20 at 09:45

pvc

1,070
1
9
14

answered Sep 28 '20 at 06:27

YvonneY

11
1

What I'm doing wrong with this structure?

3 Answers3