How would I initialise a 2D vector of objects in a constructor of a class? (C++)

Question

I am currently attempting to create a class containing a 2D vector of structs, however I am clearly doing something tragically wrong as whenever I run my code, I get the error at line 19 (the line in the for loop in the world constructor) error: expected primary-expression before ‘)’ token

Here is my code at the moment:

#include <iostream>
#include <vector>
struct Cell{
    bool isAlive;
    Cell(bool alive){
        isAlive = alive;
    }
};
class World{
    unsigned width;
    unsigned height;
    std::vector<std::vector<Cell>> state;

public:
    World(unsigned w,unsigned h){
        width = w;
        height = h;
        for (int i = 0; i<h; i++){
            state.push_back(std::vector<Cell>);
        }


    }
};

I know that I haven't yet fully initialised the 2nd dimension of the vector, but I'm just trying to get this working at the moment.

Thank you so much, I honestly have no clue what this error means.

Does this answer your question? [Initializing a two dimensional std::vector](https://stackoverflow.com/questions/17663186/initializing-a-two-dimensional-stdvector) — bloody, Dec 09 '20 at 21:37

score 0 · Accepted Answer · answered Dec 09 '20 at 21:03

You need to construct the vectors you are attempting to push_back.

// Note the added parentheses after <Cell>
state.push_back(std::vector<Cell>())

In this case, push_back is expecting a value, or an "expression" which evaluates to a value. Your expected primary expression before ')' token error more or less means that push_back was expecting a value as its parameter but was passed something else. In this case, that something else was the type std::vector<Cell>. Constructing the vector (creating a value with an expression) will fix the issue.

Thanks, that's really helpful! – CyberJelly Dec 09 '20 at 22:23 — CyberJelly, Dec 09 '20 at 22:23

score 0 · Answer 2 · answered Dec 09 '20 at 23:01

0

Ever heard of "there is no spoon"? In this case, there is no vector. You cannot pass a type, you have to pass an instance or value in this case.

answered Dec 09 '20 at 23:01

Nikkidutch

3
3

How would I initialise a 2D vector of objects in a constructor of a class? (C++)

2 Answers2