Unable to download Image from ImageView in Kotlin Causing App Crash

Question

button.setOnClickListener {

        saveToGallery()}

This is the button which is calling the saveToGallery() function

  private fun saveToGallery()
{

 val iv = findViewById<View>(R.id.photo_image) as ImageView
        val draw = iv.drawable

        val bitmap: Bitmap = draw.toBitmap()
        var outstream : FileOutputStream?=null
        val sdcard: File = Environment.getExternalStorageDirectory()
        val dir = File(sdcard.absolutePath + "/FlickrPics")
        dir.mkdirs()

        val filename:String = String.format("%d.png",System.currentTimeMillis())
        val outFile = File(dir,filename)
        try{
            outstream = FileOutputStream(outFile)
        } catch(e: Exception) {
            e.printStackTrace()

        }
        bitmap.compress(Bitmap.CompressFormat.PNG,100,outstream)
        try {
            if (outstream != null) {
                outstream.flush()

            }

        }
        catch (e: Exception){
            e.printStackTrace()

        }
        try {
            if (outstream != null) {
                outstream.close()
            }
        }
        catch (e: Exception){
            e.printStackTrace()
        }

Pls, provide the crash stack trace. – Sergey O Dec 16 '20 at 10:54 — Sergey O, Dec 16 '20 at 10:54

Nadim Ansari · Accepted Answer · 2020-12-16T12:32:01.820

0

There is problem on this Line

bitmap.compress(Bitmap.CompressFormat.PNG,100,outstream)

outstream is Null

if you put that in try catch then you see

System.err: java.io.FileNotFoundException (No such file or directory)

Conclusion:

Your File is not created it require permission (In Manifest and Runtime also)

Add this two line in manifest

<uses-permission android:name="android.permission.WRITE_EXTERNAL_STORAGE" />
<uses-permission android:name="android.permission.READ_EXTERNAL_STORAGE" />

Ask Permission Runtime

Tested Code :

private fun saveToGallery() {

    val draw = photo_image.drawable

    val bitmap: Bitmap = draw.toBitmap()
    var outstream: FileOutputStream? = null
    val sdcard: File = Environment.getExternalStorageDirectory()
    val dir = File(sdcard.absolutePath + "/FlickrPics")

    if (!dir.exists()) {
        Log.e("TAG", "is Dir Exist " + dir.exists())
        dir.mkdirs()
    } else {
        Log.e("TAG", "is Dir Exist " + dir.exists())
    }

    val filename: String = String.format("%d.png", System.currentTimeMillis())
    val outFile = File(dir, filename)
    try {
        outstream = FileOutputStream(outFile)
    } catch (e: Exception) {
        e.printStackTrace()

    }
    try {
        bitmap.compress(Bitmap.CompressFormat.PNG, 100, outstream)
    }catch (e: Exception){
        e.printStackTrace()
    }

    try {
        outstream?.flush()

    } catch (e: Exception) {
        e.printStackTrace()

    }
    try {
        outstream?.close()
    } catch (e: Exception) {
        e.printStackTrace()
    }
}

edited Dec 16 '20 at 12:32

answered Dec 16 '20 at 11:34

Nadim Ansari

574
5
20

Ask permission runtime or for now just give permission from setting (Storage),lemme know it work or not – Nadim Ansari Dec 16 '20 at 12:11
I have given storage permission from settings still not working – imanonymous Dec 16 '20 at 12:18
I have updated my answer !! i edited your code and it is working!! – Nadim Ansari Dec 16 '20 at 12:30
Thankyou,I'll check it out – imanonymous Dec 16 '20 at 12:31
please accept the answer if it will works for you – Nadim Ansari Dec 16 '20 at 12:33
App doesn't crash but this error is showing – imanonymous Dec 16 '20 at 12:39
W/System.err: at android.os.Looper.loop(Looper.java:224) – imanonymous Dec 16 '20 at 12:40
W stands for Warning not Error . And if you want to solve this warning then you have ask another question – Nadim Ansari Dec 16 '20 at 12:44
If you got the image in File manager then this question is complete – Nadim Ansari Dec 16 '20 at 12:45
I can't see the image anywhere after pressing download button – imanonymous Dec 16 '20 at 12:54
There's another error E/GraphicExt: GraphicExtModuleLoader::CreateGraphicExtInstance false can this be the reason for not downloading? – imanonymous Dec 16 '20 at 12:58
Do u have Folder "FlickrPics" in Internal Storage?? – Nadim Ansari Dec 16 '20 at 13:04
No I thought val dir = File(sdcard.absolutePath + "/FlickrPics") would create a new directory in storage – imanonymous Dec 16 '20 at 13:07
Are you getting message from this Log.e("TAG", "is Dir Exist " + dir.exists()) ?? – Nadim Ansari Dec 16 '20 at 13:08
I changes "/FlickrPics" to "Download" it is now showing as dir exist true – imanonymous Dec 16 '20 at 13:14
and you have your Image in Download Folder? – Nadim Ansari Dec 16 '20 at 13:22
No,the image doesnt get downloaded it shows java.io.FileNotFoundException: /storage/emulated/0/Download/1608125008608.png: open failed: EACCES (Permission denied) – imanonymous Dec 16 '20 at 13:24
You have give permission Runtime . Do u allowed the Storage permission from Setting of Phone? – Nadim Ansari Dec 16 '20 at 13:28
Check this https://stackoverflow.com/questions/23527767/open-failed-eacces-permission-denied Second answer will help you – Nadim Ansari Dec 16 '20 at 13:32
yes thankyou it worked you just have to enable permission storage using ContextCompat – imanonymous Dec 22 '20 at 09:57

score 0 · Answer 2 · answered Dec 22 '20 at 10:01

  private fun setupPermissions() {

        val permission =
            ContextCompat.checkSelfPermission(this, Manifest.permission.WRITE_EXTERNAL_STORAGE)
        val permissionRead = ContextCompat.checkSelfPermission(this,Manifest.permission.READ_EXTERNAL_STORAGE)
        if (permission != PackageManager.PERMISSION_GRANTED && permissionRead != PackageManager.PERMISSION_GRANTED) {
            Log.d("TAG", "Permission to Write Storage denied")
            Log.d("TAG","Permission to Read Storage denied")
            makeRequest()
        }
    }
        private fun makeRequest() {
            ActivityCompat.requestPermissions(
                this,
                arrayOf(Manifest.permission.WRITE_EXTERNAL_STORAGE,Manifest.permission.READ_EXTERNAL_STORAGE)
            ,WRITE_REQUEST_CODE)
        }

    override fun onRequestPermissionsResult(
        requestCode: Int,
        permissions: Array<out String>,
        grantResults: IntArray
    ) {
        when(requestCode){
            WRITE_REQUEST_CODE,READ_REQUEST_CODE -> {
                if(grantResults.isEmpty() || grantResults[0] != PackageManager.PERMISSION_GRANTED)
                {
                    Log.i("TAG","Permission denied")
                }
                else {
                    Log.i("TAG","Permission granted")
                }
            }
        }
    }

Unless you request for permissions explicitly it won't work, these are the codes for requesting permissions,just call setupPermissions()in main activity

Unable to download Image from ImageView in Kotlin Causing App Crash

2 Answers2