How to fix "terminate called after throwing an instance of 'std::logic_error' what(): basic_string::_M_construct null not valid" exception?

Question

I have code below that consist of binary tree data structure:

#include <bits/stdc++.h>
#define DEFAULT_NODE_VALUE 0
using namespace std;

template <class T>
class node{
public:
    T val;
    node* right = 0;
    node* left = 0;
    node(T a):val(a){}

};

template <class T>
class tree{
public:
    node<T>* root = new node<T>(DEFAULT_NODE_VALUE);
    tree(T inp_val){
        root->val = inp_val; 
    }

    void inorder_traverse(node<T>* temp){
        if (!temp)
            return;
        inorder_traverse(temp->left);
        cout << temp->val << " -> ";
        inorder_traverse(temp->right);
    }
    void inorder_traverse(){
        inorder_traverse(root);
    }
    
};

int main()
{   
    tree<string> my_tree("mantap");
    my_tree.root->right = new node<string>("ok");
    my_tree.root->left = new node<string>("haha");

    my_tree.inorder_traverse();

    return 0;
}

When I run it, it showed me an exeption like this below:

terminate called after throwing an instance of 'std::logic_error'
  what():  basic_string::_M_construct null not valid

Can anyone help me to fix this runtime error, please? Thanks in advance...

To begin with, never spam unrelated language tags (like the C language tag you have). Secondly, [don't include ``](https://stackoverflow.com/questions/31816095/why-should-i-not-include-bits-stdc-h). Thirdly get [some good C++ books](https://stackoverflow.com/questions/388242/the-definitive-c-book-guide-and-list) to learn properly, and preferably take a few classes. That should teach you why your `DEFAULT_NODE_VALUE` doesn't work for everything (or why it's not really needed). — Some programmer dude, Dec 27 '20 at 10:16
Why do you want `DEFAULT_NODE_VALUE`, when the constructor `tree::tree(T inp_val)`provides a value for `root` anyway? — Lukas-T, Dec 27 '20 at 10:19
you're specifying wrong default value of `std::string` instead use this synatx `node* root = new node(T{});` — Harry, Dec 27 '20 at 10:21

score 6 · Accepted Answer · answered Dec 27 '20 at 10:18

You're trying to initialize an std::string with 0. std::string doesn't have a ctor that takes just an int, but it does have one that takes a pointer, and an integer literal 0 can convert implicitly to a pointer--specifically, a null pointer.

But, when you pass a pointer to initialize an std::string, it's required to be a non-null pointer, so passing zero breaks things (and the error message you're getting is telling you that you've tried to break it).

My advice would be to get rid of your: DEFAULT_NODE_VALUE, and instead provide a default argument to value initialize the item in the node:

node(T a = T()):val(a){}

In which case, it'll work about as it previously did for things like node<int>, but will also work correctly for types that can't be initialized from 0. This also gets rid of the ugly DEFAULT_NODE_VALUE in the client code.

How to fix "terminate called after throwing an instance of 'std::logic_error' what(): basic_string::_M_construct null not valid" exception?

1 Answers1

Related