Why is Converting std::double to std::string using std::stod giving an exception?

Question

I am trying to get the addition done on the following method defined in my code, but after submitting the user input the program just return an exception instead of addition.

Exception:

terminate called after throwing an instance of 'std::invalid_argument' what(): stoi

This application has requested the Runtime to terminate it in an unusual way. Please contact the application's support team for more information.

Code:

#include <iostream>
#include <string>
using namespace std;
bool inputValidation_F(string userInput_VSTR1, string userInput_VSTR2)
{
    for (int inputChecker_V = 0; inputChecker_V < userInput_VSTR1.length() || userInput_VSTR1.length() && inputValidation_F; inputChecker_V ++)
        if (!(userInput_VSTR1[inputChecker_V] || userInput_VSTR2[inputChecker_V] >= 48 && userInput_VSTR1[inputChecker_V] || userInput_VSTR2[inputChecker_V] <= 57))
        return false;
    return true;
}
void mainMenu_F();
void userChoice_F();
void calCulations_F(double, double);
void resultAddition_F(double, double);
int main()
{
    mainMenu_F();
}
void mainMenu_F()
{
    cout << "Main Menu:" << '\n';
    cout << "-------------------------------" << '\n';
    cout << "Enter + for Addition" << '\n';
    cout << "-------------------------------" << '\n';
    cout << "Choose any Option from the List" << '\n';
    cout << "-------------------------------" << '\n';
    userChoice_F();
}
void userChoice_F()
{
    double addition_V_1;
    double addition_V_2;
    char uChoice_V;
    cin >> uChoice_V;
    switch (uChoice_V)
    {
    case '+':
    cout << "Addition: Enter the first value: "; cin >> addition_V_1;
    cout << "Addition: Enter the second value: "; cin >> addition_V_2;
    calCulations_F(addition_V_1, addition_V_2);
    }
}
void calCulations_F(double addition_V_1, double addition_V_2)
{
    string addition_V_1STR;
    string addition_V_2STR;
    addition_V_1 = stod (addition_V_1STR);
    addition_V_2 = stod (addition_V_2STR);
    bool additionChecker_F;
    additionChecker_F = inputValidation_F (addition_V_1STR, addition_V_2STR);
    if (!additionChecker_F)
        additionChecker_F = false;
    else resultAddition_F (addition_V_1, addition_V_2);
}
void resultAddition_F(double addition_V_1, double addition_V_2)
{
    double resultAddition_V = (addition_V_1 + addition_V_2);
    cout << "The result for the addition of the Entered values is: [" << resultAddition_V << "]" << '\n';
}

Answer 1

terminate called after throwing an instance of 'std::invalid_argument' what(): stoi

The reason's here:

void userChoice_F() {
    .
    .
    // passing two 'double' parameters
    calCulations_F(addition_V_1, addition_V_2);
}

void calCulations_F(double addition_V_1, double addition_V_2)
{
    double resultAddition_V; // redundant
    string addition_V_1STR; // created, uninitialized
    string addition_V_2STR; // created, uninitialized

    // you're overriding the parameters here
    addition_V_1 = stoi (addition_V_1STR); // convert ? to double
    addition_V_2 = stoi (addition_V_2STR); // again here
                // better put stod() with a valid string here
    .
    .
}

Firstly, you're trying to convert the string into an integer and store it in a double, that's not a very useful idea, try std::stod() instead. But still that'll fail because addition_V_1STR and addition_V_2STR are empty (never assigned before), they're useless here.

Other problems:

1. In the 6th line, you're comparing an integer to a long unsigned int, that's a bad practice.

2. In the same line, userInput_VSTR1.length() && inputValidation_F will never be NULL.

3. resultAddition_V is redundant here.

Answer 2

I think this solution will solve your Issues and Misunderstandings, Your code is edited and if you have any question, ask in comment or chat section, I will be happy to help you.

#include <iostream>
#include <string>
#include <limits>
using namespace std;
bool isvalid_(string);
bool inputValidation_F(string userInput_VSTR1, string userInput_VSTR2)
{
    for (int inputChecker_V = 0; inputChecker_V < userInput_VSTR1.length() || userInput_VSTR1.length() && inputValidation_F; inputChecker_V ++)
        if (!(userInput_VSTR1[inputChecker_V] || userInput_VSTR2[inputChecker_V] >= 48 && userInput_VSTR1[inputChecker_V] || userInput_VSTR2[inputChecker_V] <= 57))
        return false;
    return true;
}
void mainMenu_F();
void userChoice_F();
void calCulations_F(double, double);
void resultAddition_F(double, double);
int main()
{
    mainMenu_F();
}
void mainMenu_F()
{
    cout << "Main Menu:" << '\n';
    cout << "Enter + for Addition" << '\n';
    userChoice_F();
}
void userChoice_F()
{
    double addition_V_1, addition_V_2;
    char uChoice_V;
    cin >> uChoice_V;
    switch (uChoice_V)
    {
    case '+':
    cout << "Addition: Enter the first value: "; cin >> addition_V_1;
    cout << "Addition: Enter the second value: "; cin >> addition_V_2;
    while(!isvalid_("Ops! Entered invalid value, Try again."));
    calCulations_F(addition_V_1, addition_V_2);
    break;
    default:
        cout << "Invalid Choice," << '\n';
    }
}
void calCulations_F(double addition_V_1, double addition_V_2)
{
    if (!inputValidation_F)
        bool isvalid_ = 0;
    else resultAddition_F (addition_V_1, addition_V_2);
}
void resultAddition_F(double addition_V_1, double addition_V_2)
{
    double resultAddition_V = (addition_V_1 + addition_V_2);
    cout << "The result for the addition of the Entered values is: [" << resultAddition_V << "]" << '\n';
}
bool isvalid_(string err_msg)
{
    if(cin.rdstate())
    {
        cin.clear();
        cin.ignore(numeric_limits<streamsize>:: max(), '\n');
        system("cls");
        cout << "Invalid number entry! Try again from the Beginning." << '\n';
        mainMenu_F();
        return false;
    }
    return true;
}