Java Generic Wildcard Constructor not accepting objects?

Question

I have a RandomizedWrapper class. This class contains a constructor that accepts a list:

public class RandomizedWrapper{

   final int upperBound = 100;
   final List<RandomizerEntry<?>> randomizeList;
   Map<Integer, RandomizerEntry<?>> randomizerMap;

/**
 * Construct a new RandomizedWrapper instance
 * 
 * @param randomizeList - A list containing all randomizable objects
 */
public RandomizedWrapper(final List<RandomizerEntry<?>> randomizeList) {
    
    this.randomizeList = randomizeList;
    this.randomizerMap = new HashMap<>();
   }
}

I want to create a new instance of this RandomizedWrapper class. I do via the following code:

    List<RandomizerEntry<ItemStack>> randomizerList = new ArrayList<>();

    //stuff here

    RandomizedWrapper wrapper = new RandomizedWrapper(randomizerList);//error

When I attempt to create this new object, I run into the following error:

The constructor RandomizedWrapper(List<RandomizerEntry<ItemStack>>) is undefined

This makes no sense. I very clearly have a constructor in the RandomizedWrapper class that accepts a List<RandomizerEntry<?>> wildcards. A proposed solution by the compiler says "create a constructor that accepts this argument". I click that, just to see what happens, and it tells me "This constructor already exists".

Does anyone understand whats going on here? Why can't I instantiate this object?

[if you want a really long explanation](https://stackoverflow.com/questions/27902219/nested-wildcards/58631449#58631449) — Eugene, Jan 07 '21 at 02:39

SDJ · Accepted Answer · 2021-01-06T22:01:29.290

4

The issue here is that List<RandomizerEntry<ItemStack>> is not a subtype of List<RandomizerEntry<?>> so your constructor is not applicable to your argument. See this section of the Java tutorial which specifically addresses this misunderstanding.

As for the IDE suggestion to create another constructor, this won't work because in Java it is not possible to "overload a method where the formal parameter types of each overload erase to the same raw type" (details).

To solve the issue one way is simply to make the type of your local variable compatible with your constructor, although this will of course limit what you can do with it:

List<RandomizerEntry<?>> randomizerList = new ArrayList<>();

edited Jan 06 '21 at 22:01

answered Jan 06 '21 at 21:56

SDJ

4,083
1
17
35

3

Note that given the apparent purpose of this "randomizer" class, it should definitely be `RandomizedWrapper`. – chrylis -cautiouslyoptimistic- Jan 06 '21 at 22:06
Or define the constructor parameter as `List extends RandomizerEntry>>`. Though I think @chrylis suggestion makes more sense. – Slaw Jan 06 '21 at 22:20

score 4 · Answer 2 · edited Jan 07 '21 at 01:07

? (wildcars) mostly used when the generic code doesn't require any reference to a type and RandomizedWrapper isn't type of class where wildcards are needed. In this case its preferable to use Type Parameter <T> (Difference between ? (wildcard) and Type Parameter in Java)

public class RandomizedWrapper<T>{

    final int upperBound = 100;
    final List<RandomizerEntry<T>> randomizeList;
    Map<Integer, RandomizerEntry<T>> randomizerMap;

    /**
     * Construct a new RandomizedWrapper instance
     *
     * @param randomizeList - A list containing all randomizable objects
     */
    public RandomizedWrapper(final List<RandomizerEntry<T>> randomizeList) {

        this.randomizeList = randomizeList;
        this.randomizerMap = new HashMap<>();
    }


    public void create(){
        List<RandomizerEntry<Integer>> randomizerList = new ArrayList<>();
        //stuff here
        RandomizedWrapper wrapper = new RandomizedWrapper(randomizerList);//OK
    }
}

Java Generic Wildcard Constructor not accepting objects?

2 Answers2