simpler way for getting data from dictionary

Question

I have a dictionary: The last entry of a tuple are the minutes when the goals were shot. For example: Oscar a Brazilian player shot a goal in the 90th minute

players = {
    "Brazil": [
        (12, "Júlio César", "Goalkeeper", []),
        (4, "David Luiz", "Defender", []),
        (6, "Marcelo", "Defender", []),
        (13, "Dante", "Defender", []),
        (23, "Maicon", "Defender", []),
        (5, "Fernandinho", "Midfielder", []),
        (7, "Hulk", "Midfielder", []),
        (8, "Paulinho", "Midfielder", []),
        (11, "Oscar", "Midfielder", [90]),
        (16, "Ramires", "Midfielder", []),
        (17, "Luiz Gustavo", "Midfielder", []),
        (19, "Willian", "Midfielder", []),
        (9, "Fred", "Striker", []),
    ],
    "Germany": [
        (1, "Manuel Neuer", "Goalkeeper", []),
        (4, "Benedikt Höwedes", "Defender", []),
        (5, "Mats Hummels", "Defender", []),
        (16, "Philipp Lahm", "Defender", []),
        (17, "Per Mertesacker", "Defender", []),
        (20, "Jérôme Boateng", "Defender", []),
        (6, "Sami Khedira", "Midfielder", [29]),
        (7, "Bastian Schweinsteiger", "Midfielder", []),
        (8, "Mesut Özil", "Midfielder", []),
        (13, "Thomas Müller", "Midfielder", [11]),
        (14, "Julian Draxler", "Midfielder", []),
        (18, "Toni Kroos", "Midfielder", [24, 26]),
        (9, "André Schürrle", "Striker", [69, 79]),
        (11, "Miroslav Klose", "Striker", [23]),
    ],
}

I want to create a function that takes the team and a minute as input and returns the number of goals that were shot to that minute. I tried it like this:

def score_at_minute(team,minute):
    global players
    goals = [goals for (number, player, position, goals) in players[team] if len(goals)>=1]
    goals_1 = [goal[0] for goal in goals if len(goal)>=1 if goal[0] <= minute]
    goals_2 = [goal[1] for goal in goals if len(goal) ==2 if goal[1]<= minute]
    all_goals = goals_1+goals_2
    return len(all_goals)

My function call looks like this:

score_at_minute("Germany",90)

Is there a simpler way or in the best way a one liner?

`(12, "Júlio César", "Goalkeeper", [])` what are these, please describe — Epsi95, Mar 02 '21 at 09:16
This is described by the OP as: `(number, player, position, goals)` — quamrana, Mar 02 '21 at 09:16
the goals are the minutes when they were shot. I edited my post — Adrian BUdjekmd, Mar 02 '21 at 09:18
If this is **working code** that you think could be improved, see [codereview.se]. If not, please give a [mre] to illustrate the specific problem. — jonrsharpe, Mar 02 '21 at 09:20
Does this answer your question? [List comprehension on a nested list?](https://stackoverflow.com/questions/18072759/list-comprehension-on-a-nested-list) — quamrana, Mar 02 '21 at 09:29

score 3 · Answer 1 · answered Mar 02 '21 at 09:25

3

You can simply use list comprehension

# For Germany
# For less than 90 minutes
len([eg for _,_,_,g in players['Germany'] for eg in g if eg<90])

answered Mar 02 '21 at 09:25

Epsi95

8,832
1
16
34

Akshay Sehgal · Accepted Answer · 2021-03-02T09:32:35.683

1

How about this -

def score_at_minute(x,y):
    return len([j for i in players.get(x) for j in i[3] if j<=y])

score_at_minute("Germany",25)

Another version -

score_at_minute = lambda x,y: len([j for i in players.get(x) for j in i[3] if j<=y])

score_at_minute('Germany', 90)

How this works -

players.get(x) fetches the list of players and goals under the country x
i[3] is the item that holds the list of goals
When iterating over this, you will end up with a list of lists, where each sublist contains goals. [[],[],[],[24],[32,45]] .. etc.
You can now flatten the list of lists by using [item for sublist in list for item in sublist]
Then you can apply the filter over this list (less than equal to the input minutes)
Finally calculate the length.

edited Mar 02 '21 at 09:32

answered Mar 02 '21 at 09:24

Akshay Sehgal

18,741
3
21
51

thank you. I tried it with an double list comprehension but this did not work for me. Could you explain it? – Adrian BUdjekmd Mar 02 '21 at 09:27
what do you mean? doesnt this work for you? because this is a single list comprehension – Akshay Sehgal Mar 02 '21 at 09:27
Ill add an explanation. – Akshay Sehgal Mar 02 '21 at 09:28
yes it works but there are two for statements in the comprehension but now I understand it – Adrian BUdjekmd Mar 02 '21 at 09:31

score 0 · Answer 3 · answered Mar 02 '21 at 09:54

0

using items()

def score_at_minute(team,minute):        
    for key,val in players.items():
        if key==team:            
            return(len([j for i in val  for j in i[3] if j <=minute]))

answered Mar 02 '21 at 09:54

Zaynul Abadin Tuhin

31,407
5
33
63

simpler way for getting data from dictionary

3 Answers3