Output comma separated values in foreach loop

Question

I have this array:

  $bonusarraymain = array(

     array( "bonus1"=> "Testitem" , 
         ),
     array( "bonus2"=> "" , 
         ),
     array( "bonus3"=> "444" , 
         ),
     array( "bonus4"=> "" , 
         )
    );

I want to echo out the values which aren´t empty. The values should also be separated with a comma between each other. There shouldn´t be a comma after the last value.

This is how I output the values, but how can I separate them with commas?

          foreach ($bonusarraymain as $bonus) {
                echo $bonus['bonus1'];
                echo $bonus['bonus2']['0'];
                echo $bonus['bonus2']['1'];
                echo $bonus['bonus3'];
                echo $bonus['bonus4'];
            
       }

Then I have a comma after the last value. I need some check to see which value is the last so it doesn´t set a comma after this value. — Berstos, Mar 27 '21 at 01:41

charlietfl · Accepted Answer · 2021-03-27T02:11:08.123

Create a new array with those values and use implode() to insert the comma

foreach ($bonusarraymain as $bonus) {
      $items = array($bonus['bonus1'], 
                     $bonus['bonus2']['0'],
                     $bonus['bonus2']['1'],
                     $bonus['bonus3'],
                     $bonus['bonus4']);
      echo implode(',' , $items);            
}

Will leave it to you to figure out how to filter out the empty ones. Hint: array_filter()

score 1 · Answer 2 · answered Mar 27 '21 at 02:15

1

Also could use array_reduce to populate a new filtered array, then simply join the resulting array with implode.

<?php
$bonusarraymain = [
    [ "bonus1"=> "Testitem" ], 
    [ "bonus2"=> "" ],
    [ "bonus3"=> "444" ],
    [ "bonus4"=> "" ]
];

echo implode(', ', array_reduce($bonusarraymain, function($acc, $cur) {
    $cur = array_values($cur);
    if (isset($cur[0]) && !empty($cur[0])) $acc[] = $cur[0];
    return $acc;
}, []));

Result: Testitem, 444

answered Mar 27 '21 at 02:15

Lawrence Cherone

46,049
7
62
106

`isset() && !empty()` is an antipattern that should not exist in any code for any reason. https://stackoverflow.com/a/4559976/2943403 – mickmackusa Apr 29 '23 at 21:47

JohnFF · Answer 3 · 2021-03-27T01:57:14.147

0

Difficult to see what you're trying to do. Is $test supposed to be $bonus?

Update:

Use a for loop and check the index. Something like this:

for ($bonusId = 0; $bonusId < count($bonusarraymain); $bonusId++) {
  echo $bonus['bonus1'] . ",";
  echo $bonus['bonus2']['0'] . ",";
  echo $bonus['bonus2']['1'] . ",";
  echo $bonus['bonus3'] . ",";
  echo $bonus['bonus4'];

  if ($bonusId < count($bonusarraymain)-1) {
    echo ","
  }        
}

edited Mar 27 '21 at 01:57

answered Mar 27 '21 at 01:51

JohnFF

723
5
20

Yes, I changed it. But how can I get commas between the values execpt after the last one? – Berstos Mar 27 '21 at 01:52
Updated my response to contain your answer. – JohnFF Mar 27 '21 at 01:57

Output comma separated values in foreach loop

3 Answers3