It shows segmentation dump error when I use it

Question

Is there some kind of problem with this function as I have tried displacing each command but it still shows segmentation error

string splitSentence(string str)
    {
        string appendedWords{""},xx;
        for(int i=0 ; i < str.length();i++)
        {
            xx = str[i];
            if (xx == " ")
            {
                
                appendedWords = "";
            }
            else 
            {
                appendedWords = appendedWords + xx;
                
            }        
        }
    }

Tip: Don't forget that `x = x + y` is often better written as `x += y`. — tadman, Apr 29 '21 at 09:04
There is no `return` statement even though function is declared to return a `string`. — user7860670, Apr 29 '21 at 09:04
Are you trying to solve [this problem](https://stackoverflow.com/questions/236129/how-do-i-iterate-over-the-words-of-a-string)? — tadman, Apr 29 '21 at 09:04
Turn on all compiler warnings, or actually read the compiler warnings that you ignored. Even better, tell your compiler to treat warnings as errors so that you are forced to read them. — paddy, Apr 29 '21 at 09:34

score 0 · Answer 1 · answered Apr 29 '21 at 11:50

I don't know exactly what your program should do, because now it only finds the last word in your string.

I just summarized the comments and improved your code a little bit. Code

Changed parts:

pass Strings by reference
str.length() returns an unsigned integer whilst you were using an integer, this caused a compiler warning
used x+=y instead of x = x + y as tadman pointed out
added return statement

It shows segmentation dump error when I use it

1 Answers1