Find greater number of two numbers using function

Question

I try to find the greater number of the two numbers inputting by the user, using function. Please help me identify the fault I made in the code which produces a wrong result:

def func1(n1,n2):
    if (n1 > n2):
        print(n1," is greater than ",n2)
    else:
        print(n2," is greater than ",n1)

print("Find which number is greater")
num1 = input("Enter the first number: ")
num2 = input("Enter the second number: ")
func1(num1, num2)

It shows a wrong result:

Find which number is greater
Enter the first number: 10
Enter the second number: 5
5  is greater than  10

`input()` always returns a string, you need to convert those strings to numbers (`int()`) before comparing them — Iain Shelvington, May 01 '21 at 07:26
Thanks a million, yes, I changed it to like `num1 = int(input("Enter the first number: "))` to solve it. — vjwilson, May 01 '21 at 07:28
The input function produces a string value, so cast the input function — GIGO, May 01 '21 at 07:28
Personally, I don’t like, int(input...), I use Pydantic. See my example — Prayson W. Daniel, May 01 '21 at 07:43

Youcef Ali · Answer 1 · 2021-05-01T07:37:50.070

1

force input to int

def func1(n1,n2):
    if (n1 > n2):
        print(n1," is greater than ",n2)
    else:
        print(n2," is greater than ",n1)

print("Find which number is greater")
num1 = int(input("Enter the first number: "))
num2 = int(input("Enter the second number: "))
func1(num1, num2)

for your function you can acheive that in one line

def func1(n1,n2):
        return str(n1)+" is greater than "+str(n2) if n1>n2 else str(n2)+" is greater than "+str(n1)

edited May 01 '21 at 07:37

answered May 01 '21 at 07:32

Youcef Ali

189
1
6

Wow actually didn't know you could put if statement in one line – Korogue Apr 07 '22 at 21:41

score 0 · Answer 2 · answered May 01 '21 at 07:32

The reason is, the input function produces a string value. So changed the code to like:

def func1(n1,n2):
    if (n1 > n2):
        print(n1," is greater than ",n2)
    else:
        print(n2," is greater than ",n1)

print("Find which number is greater")
num1 = int(input("Enter the first number: "))
num2 = int(input("Enter the second number: "))
func1(num1,num2)

Output:

Find which number is greater
Enter the first number: 5
Enter the second number: 10
10  is greater than  5

score 0 · Answer 3 · answered May 01 '21 at 07:38

0

via f-string -

def func1(n1,n2):
    print(f'{n1} is greater than {n2}' if (n1> n2) else f'{n1} is greater than {n2}')


print("Find which number is greater")
num1 = int(input("Enter the first number: "))
num2 = int(input("Enter the second number: "))
func1(num1,num2)

answered May 01 '21 at 07:38

Nk03

14,699
2
8
22

Can you explain what is f-string? – vjwilson May 01 '21 at 07:39
read [here](https://realpython.com/python-f-strings/) or watch [this](https://realpython.com/lessons/f-strings/) video. – nobleknight May 01 '21 at 07:41
f-strings are not only more readable, more concise, and less prone to error than other ways of formatting, but they are also faster!. Plus, you can add conditions to manipulate strings :) – Nk03 May 01 '21 at 07:41

Prayson W. Daniel · Answer 4 · 2021-05-01T07:53:13.350

Using pydantic. You can python -m pip install --user pydantic.

Pydantic will help you perform data validation, conversation and friendly errors when data is invalid.

from pydantic import BaseModel

class InputValues(BaseModel):
    n1: int
    n2: int


def f(n1,n2):
   # let PyDantic deal with conversation 
    num = InputValues(n1=n1, n2=n2)
    if (num.n1 > num.n2):
        print(f"{n1} is greater than {n2}")
    else:
        print(f"{n2} is greater than {n1}")

# Example:

n = "10"
m = "5"

f(n,m)

Why use Pydantic over simple casting

int(input...) will fail if invalid input are passed. The different between the two is that one will tell you exactly what the problem is.

You can find more on pydantic

Find greater number of two numbers using function

4 Answers4

Why use Pydantic over simple casting