How should I define a collection method that returns an array?

Question

I would like to know what I should do to make the array list be returned properly. Currently I am getting this error on each line of the testing method where get(o), get(1) etc: cannot find symbol symbol: method get(int) location: interface Collection

see here: error image

I have also tried other methods such as assertThat which did not work.

I have a testing method that looks like this:

 @Test
    public void testSaveCar() {
        dao.saveCar(car3);
    
        assertEquals(dao.getCars().get(0), car1.getCarId());
        assertEquals(dao.getCars().get(1).getCarId(), car2.getCarId());
        assertEquals(dao.getCars().get(2).getCarId(), car3.getCarId());
        dao.removeCar(car3);
    
    }

and a jdbcdao class that looks like this:

/**
 *
 *
 */
public class CarJdbcDAO implements CarDAO {

    private String url = JdbcConnection.getDefaultConnectionUri();

    public CarJdbcDAO() {
    }

    public CarJdbcDAO(String uri) {
        this.url = uri;
    }

   

    @Override
    public Collection<Car> getCars() {
        

        String sql = "select * from Car";
        try (
            Connection dbCon = JdbcConnection.getConnection(url); //get connection to db
            PreparedStatement stmt = dbCon.prepareStatement(sql); //create stmt
            ) {
            ResultSet rs = stmt.executeQuery(); 

            List<Car> carsList = new ArrayList<>(); 

            //iterate through query results
            while (rs.next()) {
                            

                
                    String carId = rs.getString("Car_Id");
                    String carName = rs.getString("Car_Name");
                    
                    String carType = rs.getString("Car_Type");
                    String seatNumber = rs.getString("Seat_Number");
                    BigDecimal hourlyCharge = rs.getBigDecimal("Hourly_Charge");
                    String location = rs.getString("Location");
                                                
                                                Car car = new Car(carId, carName, carType, seatNumber, hourlyCharge, location);
                                                

                carsList.add(car); 

            }

            return carsList;

        } catch (SQLException ex) {
            throw new DAOException(ex.getMessage(), ex);
        }
    }

Which line is the error on? You should attempt to produce a small example demonstrating the problem rather than showing lots of code that isn't relevant. — sprinter, May 11 '21 at 03:01
Sorry about that. I have since updated with a photo and more detail. — stefanks, May 11 '21 at 03:06

sprinter · Answer 1 · 2021-05-11T03:22:55.523

2

getCars returns a Collection which is not the same as a list. Specifically it does not allow you to get an item using an index.

The better way to assert that a collection contains certain items is to use:

assertThat(dao.getCars(), hasItems(car1, car2));

This is using the Hamcrest assertion library which is the one that is normally used with junit. You could use an alternative assertion library such as AssertJ that would allow:

assertThat(dao.getCars()).containsExactly(car1, car2);

AssertJ also lets you extract fields if you don't have equals defined:

assertThat(dao.getCars()).extracting("id").contains(id1, id2);

edited May 11 '21 at 03:22

answered May 11 '21 at 03:17

sprinter

27,148
6
47
78

Thanks for your reply. I have already tried using assertThat, however the test can't seem to pick up the object even though they are identical. Could it be possible I am using the wrong imports? Link to old error with assertThat: https://stackoverflow.com/questions/67478929/why-am-i-getting-an-assertion-error-when-there-should-be-a-match-junit/67479152#67479152 – stefanks May 11 '21 at 03:25
You would need to have `equals` defined for `Car` for the assertion to work. – sprinter May 11 '21 at 11:42

How should I define a collection method that returns an array?

1 Answers1