Fix errors for checking integers in lists

Question

When I run this code; even when the list contains only numbers, it still returns as an error when it should return [1, 2, 3]. How can I fix this issue?

def check_integer(a, b, c):

  if type([a, b, c]) !=  int:
    raise TypeError("Must be numbers.")
  else:
    return [a, b, c]

print (check_integer(1, 2, 3))

Does this answer your question? [Check if all elements of a list are of the same type](https://stackoverflow.com/questions/13252333/check-if-all-elements-of-a-list-are-of-the-same-type) — Yoshikage Kira, May 27 '21 at 07:00
You are passing a list and checking wihether it is int or not. Your logic is incorrect — Abhishek Aggarwal, May 27 '21 at 07:01
https://stackoverflow.com/questions/16908186/python-check-if-list-items-are-integers — Pygirl, May 27 '21 at 07:03

score 1 · Answer 1 · answered May 27 '21 at 07:06

try using all and iterate over each elements:

def check_integer(a, b, c):

    if not all(type(i)==int for i in [a,b,c]):
        raise TypeError("Must be numbers.")
    else:
        return [a, b, c]

print (check_integer(1, 2, 3))

[1, 2, 3]

Efficient way of doing:

def check_integer(*params):

    if not all(type(i)==int for i in params):
        raise TypeError("Must be numbers.")
    else:
        return params

print (check_integer(*[1,2,3]))

score 0 · Answer 2 · answered May 27 '21 at 07:03

0

def check_integer(a, b, c):

  if not (type(a) is int and type(b) is int and type(c) is int):
    raise TypeError("Must be numbers.")
  else:
    return [a, b, c]


print(check_integer(1, 2, 3))

this is correct code.

answered May 27 '21 at 07:03

Abhishek Aggarwal

190
9

score 0 · Answer 3 · answered May 27 '21 at 07:08

0

A generalized solution:

def check_integer(*args):
    if not all([type(i) == int for i in [*args]]):
        raise TypeError("Must be numbers.")

    return args

answered May 27 '21 at 07:08

nocibambi

2,065
1
16
22

JMA · Answer 4 · 2021-05-27T07:33:58.087

0

This is a way to do it:

def check_integers(*args):

    if not all(isinstance(i, int) for i in args):
        raise TypeError("Must be numbers.")
    
    return list(args)

You can add other types in the second argument of isinstance as a tuple (ej. isinstance(var, (int, float))).

edited May 27 '21 at 07:33

answered May 27 '21 at 07:14

JMA

803
4
9

Fix errors for checking integers in lists

4 Answers4