I was doing session handling in asp.net MVC it works on view page button i was unable to get session on another action in my controller

Question

I was getting data from the database in this controller and then I am storing the username into a session it works when I move to the view page after login.

public ActionResult shoppage(assign s)
{

    if (ModelState.IsValid)
    {
        using (transactionEntities db = new transactionEntities())
        {
            var obj = db.assigns.Where(a => a.Username.Equals(s.Username) && a.Password.Equals(s.Password)).FirstOrDefault();
            if (obj != null)
            {
                Session["Username"] = s.Username.ToString();

                return View();
            }
            else
            {
                return RedirectToAction("login");
            }
        }

But when I try to access it in another action result it gives me a null value exception

public ActionResult insertwatch()
{
    if (Session["Username"] != null)
    {
        name = Session["Username"].ToString();
    }

    if (Request.Form["submit1"] != null)
    {
        transactionEntities dt = new transactionEntities();
        itemthing it = new itemthing();
        it.uname = name.ToString();
        it.itemprice = "1200";
        it.itemname = "lucia";
        dt.itemthings.Add(it);
        return RedirectToAction("shoppage");
    }
    else if (Request.Form["submit2"] != null)
    {
        transactionEntities dt = new transactionEntities();
        itemthing it = new itemthing();
        it.uname = name.ToString();
        it.itemprice = "1800";
        it.itemname = "Benson";
        dt.itemthings.Add(it);
        return RedirectToAction("shoppage");
    }

Error:

Does this answer your question? [What is a NullReferenceException, and how do I fix it?](https://stackoverflow.com/questions/4660142/what-is-a-nullreferenceexception-and-how-do-i-fix-it) — Yong Shun, Jun 26 '21 at 06:12
I am not able to understand your question. Are you trying to assign a new value to the session variable which is already assigned ? — neehu, Jun 26 '21 at 07:24

Pritom Sarkar · Answer 1 · 2021-06-26T08:25:41.290

You may need to add a null check the property:-

 public ActionResult shoppage(assign s)
    {

        if (ModelState.IsValid)
        {
            using (transactionEntities db = new transactionEntities())
            {
                var obj = db.assigns.Where(a => a.Username.Equals(s.Username) && a.Password.Equals(s.Password)).FirstOrDefault();
                if (obj != null)
                {
                     if (HttpContext.Current.Session["Username"] == null)  //add this code
                          return string.Empty;
                    else
                        //Session["Username"] = s.Username.ToString();
                        HttpContext.Current.Session["Username"] = s.Username.ToString();

                    return View();
                }
                else
                {
                    return RedirectToAction("login");
                }
            }

Or you can simply use this line of code:-


//clarify code

if (Session["Username"]!=null)
{
   Session["Username"] = s.Username.ToString();
   return View();
}

//clarify code

Or you can use something like that of the set session and get the store value of the session:-

Set the Session

string user = s.Username.ToString();   
HttpContext.Session.SetString("UserToken", user);

Get the stored value from the session:-

var token = HttpContext.Session.GetString("UserToken");

I think it will resolve your issue.

if (Session["Username"]!=null) { Session["Username"] = s.Username.ToString(); return View(); } i have already used this in my project but its not working — yaseen, Jun 26 '21 at 08:36

I was doing session handling in asp.net MVC it works on view page button i was unable to get session on another action in my controller

1 Answers1