Not sure what is causing error c2600 in code

Question

I have looked at other forum posts and I am still confused. I am very new to coding so a simple answer would be appreciated. I am trying to create a simple program that uses sets and gets to set the player's attributes and then gets them with functions. However, whenever I call the functions I get the error.

Here is my .h file:

#pragma once

#include <iostream>
#include <dos.h>
#include <string>
#include <sstream>
using namespace std;

class Player
{
    private:
        string name;
        int health;
        int strength;
        int stamina;
        int experience;
        bool passive;
    public:
        string GetName();
        string SetName(string tName);
        int GetHealth();
        int SetHealth(int tHealth);
        int GetStrength();
        int SetStrength(int tStrength);
        int GetStamina();
        int SetStamina(int tStamina);
        int GetExperience();
        int SetExperience(int tExperience);
        bool GetPassive();
        bool SetPassive(bool tPassive);
};

And here is my 1st then 2nd cpp file:

#include <iostream>
#include <iostream>
#include <dos.h>
#include <string>
#include <sstream>
#include "C:\\Users\\Ryan Bell\\Desktop\\School\\2nd Year\\Quarter 1\\Programming\\Week 1\\PlayerClass\\PlayerClass\\PlayerClass.h"


Player::Player()
{
    name = "";
    health = 100;
    strength = 30;
    stamina = 100;
    experience = 20;
    passive = false;
}

string Player::GetName()
{
    return name;
}

string Player::SetName(string tName)
{
    name = tName;
    return "Ok";
}

int Player::GetHealth()
{
    return health;
}

int Player::SetHealth(int tHealth)
{
    health = tHealth;
}

int Player::GetStrength()
{
    return strength;
}

int Player::SetStrength(int tStrength)
{
    strength = tStrength;
}

int Player::GetStamina()
{
    return stamina;
}

int Player::SetStamina(int tStamina)
{
    stamina = tStamina;
}

int Player::GetExperience()
{
    return experience;
}

int Player::SetExperience(int tExperience)
{
    experience = tExperience;
}

bool Player::GetPassive()
{
    return passive;
}

bool Player::SetPassive(bool tPassive)
{
    passive = tPassive;
}

#include <iostream>
#include <iostream>
#include <dos.h>
#include <string>
#include <sstream>
#include "C:\\Users\\Ryan Bell\\Desktop\\School\\2nd Year\\Quarter 1\\Programming\\Week 1\\PlayerClass\\PlayerClass\\PlayerClass.h"

int main()
{
    Player Player1;
    Player1.SetName("Jake");
    Player1.SetHealth(100);
    Player1.SetStrength(30);
    Player1.SetStamina(50);
    Player1.SetExperience(0);
    Player1.SetPassive(true);

    cout << "Player " << Player1.GetName() << ".";
}

Thank you for your time and help!

Answer 1

I don't see a Player Constructor declared:

// I see the Player Constructor definition here.
Player::Player()
{
    .....

But this method is not declared in the class.

class Player
{
    private:
    .....
    public:
        Player();           // Add this line.
        string GetName();

PS. Your code should compile and "probably" runs but is not good. If you can show it working, you can take it to Code Review and get them to give you advice on how to make it better (and some obvious errors corrected).

Answer 2

The compilation of your code gives:

2.cpp: In member function ‘int Player::SetStamina(int)’:
2.cpp:18:1: warning: no return statement in function returning non-void [-Wreturn-type]
   18 | }
      | ^
2.cpp: In member function ‘int Player::SetExperience(int)’:
2.cpp:28:1: warning: no return statement in function returning non-void [-Wreturn-type]
   28 | }
      | ^
2.cpp: In member function ‘bool Player::SetPassive(bool)’:
2.cpp:38:1: warning: no return statement in function returning non-void [-Wreturn-type]
   38 | }

These can be fixed by turning all setters as functions returning void, e.g:

void Player::SetStamina(int tStamina)

Do it both in *.h and player.cpp.

After fixing this, we bump onto linker errors:

/usr/bin/ld: /tmp/ccQk0cvm.o: in function `main':
main.cpp:(.text+0x6c): undefined reference to `Player::SetName(std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >)'
/usr/bin/ld: main.cpp:(.text+0xa7): undefined reference to `Player::SetHealth(int)'
/usr/bin/ld: main.cpp:(.text+0xb8): undefined reference to `Player::SetStrength(int)'
/usr/bin/ld: main.cpp:(.text+0x11a): undefined reference to `Player::GetName[abi:cxx11]()'
collect2: error: ld returned 1 exit status

This means that you forgot to define Player::GetName, Player::SetStrength(int), and 2 other methods.

This leads us to the simplest solution (for now): modify the public section of your class so that it implements all functions:

    public:
        std::string GetName() const { return name; }
        void SetName(string tName) { name = tName; }
        int GetHealth() const { return health; }
        void SetHealth(int tHealth) { health = tHealth; }
        int GetStrength() const { return strength; }
        void SetStrength(int tStrength) { strength = tStrength; }
        int GetStamina() const { return stamina; }
        void SetStamina(int tStamina) { stamina = tStamina; }
        int GetExperience() const { return experience; }
        void SetExperience(int tExperience) { experience = tExperience; }
        bool GetPassive() const { return passive; }
        void SetPassive(bool tPassive) { passive = tPassive; }

and don't use a separate source file for the class member definitions.

Alternatively, you can keep the file, but then you must add all missing function definitions in it.

Notice that I declared all getters as const member functions. Believe me, this is how they should be defined.